Update revive to 0.1.0-dev.8 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
approved these changes
Jan 20, 2025
| @@ -14,7 +14,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: revive-remix-backend | |||
| image: paritytech/revive-remix-backend:1.3.5 | |||
| image: paritytech/revive-remix-backend:1.3.6 | |||
There was a problem hiding this comment.
What versioning is this following?
There was a problem hiding this comment.
Now Minor update is the change in backend logic
Revive change is the Patch update
There was a problem hiding this comment.
I think it would make sense to use the revive version in the tag? Then you don't need to do this when actually nothing changed: There can be multiple version of the revive-remix_backend but the images include different revive versions. As a side effect it's directly visible what compiler version is deployed too.
There was a problem hiding this comment.
I think that it may be the last backend release, so probably it does not make sense to introduce any changes now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.