Skip to content

fix(era-utils): validate export range and error on post-clamp invalid ranges #19987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(era-utils): validate export range and error on post-clamp invalid ranges #19987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/era-utils/src/export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ impl ExportConfig {
return Err(eyre!("Max blocks per file cannot be zero"));
}

if self.first_block_number > self.last_block_number {
return Err(eyre!(
"First block ({}) must be less than or equal to last block ({})",
self.first_block_number,
self.last_block_number
));
}

Ok(())
}
}
Expand All @@ -97,6 +105,14 @@ where
// best_block_number() might be outdated, so check actual block availability
let last_block_number = determine_export_range(provider, config)?;

if config.first_block_number > last_block_number {
return Err(eyre!(
"First block ({}) is greater than the highest available block ({}) after clamping to head. Reduce --first-block-number or sync further.",
config.first_block_number,
last_block_number
));
}

info!(
target: "era::history::export",
first = config.first_block_number,
Expand Down
Loading