fix(era-utils): validate export range and error on post-clamp invalid ranges #19987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a UX issue in export-era where an invalid range could lead to a silent no-op. Previously,
ExportConfig::validate() did not check that first_block_number <= last_block_number, and after clamping the last block to the chain head in export(), the effective range could still become invalid, resulting in no files being produced while the command reported success. We now validate the range in two places: in ExportConfig::validate() to catch obvious misconfiguration early, and in export() immediately after clamping to ensure the effective range remains valid. If the first block exceeds the effective last block, we return a clear error suggesting to lower --first-block-number or sync further. This aligns the behavior with other CLI tools that enforce range correctness (e.g., dump-stage), prevents user confusion, retains support for single-block exports (first == last), and keeps defaults intact.