[Part 2 - option 1] feat: refactor v4 to infinity #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
changed the title
ChefMist
commented
Jan 31, 2025
| @@ -0,0 +1,27 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
originally at https://github.com/pancakeswap/infinity-periphery/blob/main/src/pool-cl/interfaces/IERC721Permit.sol
moved up as its also used by SelfPermitERC721 (at src/base/SelfPermitERC721)
ChefMist
commented
Jan 31, 2025
| @@ -1,27 +1,38 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
this file was from https://github.com/pancakeswap/infinity-periphery/blob/main/src/pool-cl/interfaces/IERC721Permit_v4.sol and renamed to IERC721Permit.sol
ChefMist
changed the title
2 tasks
Co-authored-by: Chef Omelette <[email protected]>
chef-omelette
approved these changes
Feb 3, 2025
|
Also prefer this option as those interfaces are general and we didn't apply any changes to them |
chefburger
approved these changes
Feb 5, 2025
chefburger
pushed a commit
that referenced
this pull request
Feb 5, 2025
* forge install: infinity-core * feat: remove v4-core dependency * feat: update import and v4 router -> infinity router * bump infinity-core dep to feat/refactor-name branch * feat: update script from v4 to infinity * feat: further rename of v4 to infinity * feat: further refactoring of v4 -> infinity * feat: more refactoring * feat: rename Multicall_v4 to MultiCall * refactor v4 -> infi from migrator * feat: further refactor in quoter * feat: further rename for v4->infinity * feat: more refactor or v4 -> infinity * [Part 2 - option 1] feat: refactor v4 to infinity (#78) * feat: rename _v4 to without _v4 * Update src/interfaces/external/IV3NonfungiblePositionManager.sol Co-authored-by: Chef Omelette <[email protected]> --------- Co-authored-by: Chef Omelette <[email protected]> --------- Co-authored-by: Chef Omelette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
src/pool-bin/interfaces/IERC721Permit.soltosrc/interfaces/IERC721Permit.solsrc/pool-cl/interfaces/IEIP712_v4tosrc/pool-cl/interfaces/IEIP712src/pool-cl/interfaces/IEIP712Permit_v4tosrc/pool-cl/interfaces/IEIP712PermitThis is option 1:
Option 1: Rename _v4 to be without suffix (but might collide if hardhat import) - [Part 2 - option 1] feat: refactor v4 to infinity #78
Option 2: Rename _v4 to _infi - [Part 2 - option 2] feat: refactor v4 to infinity #79