feat: refactor v4 to infinity #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefMist
changed the title
ChefMist
changed the title
src/modules/V3ToInfinityMigrator.sol
Outdated
| @@ -71,16 +71,16 @@ abstract contract V3ToV4Migrator is RouterImmutables { | |||
| } | |||
| } | |||
|
|
|||
| /// @dev check that the v4 position manager call is a safe call | |||
| /// @dev check that the cl position manager call is a safe call | |||
There was a problem hiding this comment.
Suggested change
| /// @dev check that the cl position manager call is a safe call | |
| /// @dev check that the infinity cl position manager call is a safe call |
src/modules/V3ToInfinityMigrator.sol
Outdated
| @@ -105,16 +105,16 @@ abstract contract V3ToV4Migrator is RouterImmutables { | |||
| } | |||
| } | |||
|
|
|||
| /// @dev check that the v4 position manager call is a safe call | |||
| /// @dev check that the bin position manager call is a safe call | |||
There was a problem hiding this comment.
Suggested change
| /// @dev check that the bin position manager call is a safe call | |
| /// @dev check that the infinity bin position manager call is a safe call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on option 1 of of pancakeswap/infinity-periphery#78 -- which assume foundry will be used moving forward, so the worries about clashing due to hardhat (or maybe hardhat might resolve that down the road) should not be present
This PR refactor v4 related to infinity