Separate signature from docstring on hover

[mpanarin]

LSP supports MarkedString[] to specify render engine. We can definitely say that function signature should be rendered as python.
For the docstring, as we have no good way of parsing it to guess the engine, we can pass it as markdown.

[ccordoba12]

@andfoy, please take a look at this one.

[andfoy]

I think we should aim to support Markdown fully using MarkupContent, i.e., Finishing #348

[mpanarin]

@andfoy Well, that pr implements rst2md converter. Which is wrong, as python docs come in different shape and sizes. And without some specific parsers/converters is there an actual point in that?
While here we basically say render signature as python, everything else as markdown (whatever there is).

[gatesn]

I wonder if there's a set of "tell-tale" signs that a docstring is in markdown vs rst vs plain text. In such a way that if those signs aren't there, then it's likely it doesn't matter what format we treat it as.

e.g. hello is valid markdown, rst and plain text. Whereas ..<directive>: is clearly an RST doc.

[mpanarin]

@gatesn I updated this pull requrest

In jedi 15.0 author added a proper way to get a signature of a function here which allows us to grab signature and docstring separately, formatting them accordingly.
Imo, these is reasonable enough change to make the dependency on jedi >= 0.15.0 as it can definitely be used in jedi_completion as well (I didn't check specific use, but I am sure it is there.) making code clearer.
If accepted, supersedes #635

About your comment on hover.contentFormat those are the types of MarkupKind - plaintext or markdown. So this should work fine as we follow markdown route.

For a tell-tale signs - this is a good thing for a research. But as I said earlier - it is a huge amount of work, and docstring at the moment are not highlighted properly. Which is a shame.

[ccordoba12]

I left a minor comment, otherwise looks good to me.

@gatesn?

[samiur]

Would love to see this merged, as I'd like the Jedi requirements update

[mpanarin]

@ccordoba12 ping on this one )

[ccordoba12]

Thanks for your patience @mpanarin!

[maximbaz]

Hey guys, would you please cut off a new release targeted the latest python-jedi? It seems 0.29.0 milestone is complete anyway 😉