Skip to content

Don't limit jedi to <0.15 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't limit jedi to <0.15 #654

wants to merge 1 commit into from

Conversation

mcepl
Copy link

@mcepl mcepl commented Sep 11, 2019

Tests pass without failure (82 passed, 5 skipped), and it improves my life (a Linux Python maintainer) so I use system jedi in openSUSE. I will create the system package of pyls.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/python-language-server, @mcepl! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ccordoba12
Copy link
Contributor

The update to Jedi 0.15 is being handled in PR #623, which we haven't had time to test with Spyder (I'm the Spyder maintainer and started to co-maintain this project as part of our move to use the Language Server Protocol in our Editor).

@ccordoba12 ccordoba12 closed this Sep 11, 2019
@gatesn
Copy link
Contributor

gatesn commented Sep 11, 2019

@ccordoba12 what do you think of just not placing an upper bound on Jedi and fixing when issues arise? The API surface we use shouldn’t change too frequently. As far as I’m aware the breaks we’ve seen have been with the new environment APIs which seem to have somewhat stabilised now.

I’ll allow @davidhalter to comment, but I don’t believe it’s his intention to break with every minor version - even if strictly speaking it is allowed by semver pre-1.0.

Perhaps it is time to push for a Jedi 1.0?

@ccordoba12
Copy link
Contributor

ccordoba12 commented Sep 11, 2019

@gatesn, we've been using Jedi for a long time (since version 0.8, I think) and usually major releases (e.g. from 0.10 to 0.11) break stuff.

Since we provide an automatic way for Spyder users to report errors to our Github issue tracker, we've been flooded by Jedi issues (say 20 to 30 issues per day for three or four days) when a new version comes up. That's why I'd like to be on the conservative side here.

However, in order to not steer this project only towards Spyder needs, I'll add a requirement in Spyder to not use a new PyLS version until we properly test it, I'll merge #623 (which agrees with the LSP reference just fine) and release 0.29 with it.

@mcepl mcepl deleted the no-upper-limit-jedi branch September 11, 2019 14:29
@davidhalter
Copy link

I totally understand not updating Jedi automatically. IMO it hasn't been an issue since the environemt changes (0.11 to 0.12 I think), but there might still be issues if you use a different feature set than other solutions.

So I would probably not auto-upgrade, but it's generally a good idea to upgrade as soon as possible, because the upgrades usually contain bug fixes and new cool features. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants