-
Notifications
You must be signed in to change notification settings - Fork 50
[Reconfigurator] Host OS update planner support #8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a heads up that I'm changing some of the unit test structure for mgs_updates/mod.rs to account for more components here -> https://github.com/oxidecomputer/omicron/pull/8664/files#diff-7c888dfce867a1f4a2b025ee3a82410a7ef7b14785ce5a795083aa4ff148dcd9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing this! It shouldn't clash too terribly with what I had before d4f31f9 I'll keep a look out.
Ahh, thanks. Honestly I'm finding the unit test stuff a little unwieldy, so I was going to take a swing at some cleanup before adding host OS unit tests. I was building off of main for that cleanup, but maybe I should build off of your branch instead? |
eae3c4e
to
0fe7dd2
Compare
0fe7dd2
to
8deb34f
Compare
I think this is ready for review (demo'd today on dublin!). The diff is quite large but the vast majority is test code, and over half the diff is expectorate output. It's probably still worth reviewing that output at least at a superficial level, particularly the |
This isn't ready to merge yet; in particular, there aren't any new planner unit tests. I'm opening this now to avoid conflicting with changes @karencfv is making to the reconfigurator-cli tests (which do have updates for host OS planning on this branch).