-
Notifications
You must be signed in to change notification settings - Fork 52
[reconfigurator-cli] Populate simulated caboose and test RoT update #8835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reconfigurator-cli] Populate simulated caboose and test RoT update #8835
Conversation
version: version.to_string(), | ||
sign: None, | ||
sign: Some(board), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tufaceous uses the board name as the sign for the artifact's cabooses
We can do the same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to land this before the host OS planner stuff; that's going to be a little while longer before it's ready. If you change the inputs to use latest
instead of raw UUIDs, fixing up the merge conflicts shouldn't be too bad.
@@ -31,46 +31,78 @@ sled-list | |||
blueprint-list | |||
inventory-list | |||
|
|||
# First step: upgrade one SP. | |||
# First step: upgrade one RoT. | |||
blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized this way too late when I was working in this file, but: you can change all of the blueprint-plan
lines to
blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 | |
blueprint-plan latest latest |
(for "base of the latest blueprint" and "use the latest collection") to avoid having to manually shuffle all these UUIDs around when we make changes.
@@ -31,46 +31,78 @@ sled-list | |||
blueprint-list | |||
inventory-list | |||
|
|||
# First step: upgrade one SP. | |||
# First step: upgrade one RoT. | |||
blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 | |||
blueprint-diff dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, all of these can be just
blueprint-diff dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1 | |
blueprint-diff latest |
for "diff the latest blueprint against its parent".
I've merged #8664. So, I'll update this PR to include RoT bootloader tests as well. I can't merge this PR as is because once the cabooses have a |
EDIT: #8631 was merged 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PR to include testing RoT bootloader as well. Would appreciate another look!
Will merge as it had merge conflicts a couple of times now and tomorrow is Saturday for me. It's only tests so we can adjust these if necessary. |
This turned out to be way easier than I anticipated. @jgallagher I know this clashes with your host OS planner PR, happy to hold off merging this until you merge your PR if you prefer 😄
Related: #8798