-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] Migrate from setup.py/setuptools to pyproject.toml/hatch #1190
Comments
This is a great opportunity to try out the newly released sub-issues ;) |
Already started it for tutor-indigo overhangio/tutor-indigo#116 |
@ghassanmas @CodeWithEmad @jfavellar90 Can you take care of your respective plugins, please? Thanks |
That cool. I'll take care of the cookie-cutter in the coming days. Update: Here you are: overhangio/cookiecutter-tutor-plugin#40 |
@ghassanmas @jfavellar90 A reminder. Let me know if you do not have the capacity to take this on. Thanks |
@DawoudSheraz I'll reserve capacity this week :) |
@DawoudSheraz Re tutor-forum, I'm afraid you may have me confused with someone else. :) I am not a tutor-forum contributor, and the Open edX platforms I help maintain don't use it. Could you have mixed up some names/handles? |
Oh, sorry. I tagged you accidentally. Apologies for the confusion. I have updated it. |
No problem, thanks! |
@DawoudSheraz notes and xqueue PR's ready |
This larger issue originated from the work done in tutor core PR #1163. The PR aimed to fix #956 by switching to hatch as a project builder/manager. This change needed to have an updated pyproject.toml and potentially migrate setup.py to pyproject.toml. To ensure consistency across the codebase, the change should be done across core, tutor plugins, and plugin cookie-cutter.
Action items / PRs
Related Links
When initializing a new hatch project, it automatically converts setup.py to pyproject. However, it won't be enough / might not be correct. We would need to config some metadata dynamically. Python docs highlight the synonymous pyproject fields for related setuptools fields. Ensure the build works as expected after the change. You might need to change commands where needed.
Note
When using
pip show <package_name>
, it is possible some fields, like license and author name, might not render. This is due to how hatch handles them internally.You can look into the following for additional context
The text was updated successfully, but these errors were encountered: