feat: migrate from setup.py/setuptools to pyproject.toml/hatch #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Danyal-Faheem
commented
Feb 6, 2025
Danyal-Faheem
commented
- migrate from setup.py and setuptools to pyproject.toml and hatch as part of https://peps.python.org/pep-0621/
- completes tutor-minio action item from [Epic] Migrate from setup.py/setuptools to pyproject.toml/hatch tutor#1190
- Updates maintainer email to new maintainer
Danyal-Faheem
force-pushed
the
danyal/migrate-to-pyproject
branch
from
ff3f67a to
0fc3827
Compare
14 tasks
Comment on lines
+36
to
+37
| "pylint", | ||
| "black" |
There was a problem hiding this comment.
They are not in setup.py. Are they needed here?
There was a problem hiding this comment.
These were added so that the command make test works as expected to run normal tests since it requires both pylint and black. Previously, one had to install these themselves when working with minio codebase.
DawoudSheraz
approved these changes
Feb 13, 2025
|
@Danyal-Faheem Should I go ahead and merge this? Or do you need another review? |
|
Let's go ahead with this one. I think this is mature enough now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.