fix: author name, email and license name in pyproject.toml #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeWithEmad
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these issues have been mentioned in the parent epic: overhangio/tutor#1190
The author name is a known issue where it would display both the email and name against the author name and email against the author-email field. By changing it to two different json objects, it displays name and email against their respective headings.
The license would display the entire file when we ran
pip show pluginwhich would make everything cluttered, hence we decided to limit it to just the license name. Reference discussion: overhangio/tutor#1163 (comment)P.S, I will need some confirmation on the BSD license name. We should be using the ones specified in the SPDX License list but BSD has a lot of different names.