Sharing tsconfig across packages #359
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
| @@ -1,23 +1,7 @@ | |||
| { | |||
| "extends": "tsconfig/tsconfig.json", | |||
There was a problem hiding this comment.
would it be smart to call this "@zoralabs/tsconfig" even it it's private in the case there is a package collision?
There was a problem hiding this comment.
not a bad idea - also would improve understandability of what the import references. will do.
There was a problem hiding this comment.
ok I tried that, but now get an error:
error Couldn't find package "@zorlabs/tsconfig@*" required by "@zoralabs/[email protected]" on the "npm" registry.
See #361
I believe its a limitation of private packages within the same repo that they cannot be namespaced like that.
what if we called it zoralabs-tsconfig ?
packages/tsconfig/package.json
Outdated
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "name": "tsconfig", | |||
There was a problem hiding this comment.
thoughts on @zoralabs/tsconfig even if it's never published would prevent collisions.
oveddan
force-pushed
the
shared-tsconfig
branch
from
aec093d to
663fafb
Compare
* wip on shared tsconfig * update to use shared tsconfig * adding missing config
* wip on shared tsconfig * update to use shared tsconfig * adding missing config
* wip on shared tsconfig * update to use shared tsconfig * adding missing config
No description provided.