Sharing tsconfig across packages (#359)

oveddan · kulkarohan · commit d4717c6372ad · 2023-12-08T12:49:00.000-05:00
* wip on shared tsconfig

* update to use shared tsconfig

* adding missing config
diff --git a/packages/1155-contracts/package.json b/packages/1155-contracts/package.json
@@ -53,6 +53,7 @@
     "prettier-plugin-solidity": "^1.1.3",
     "@types/node": "^20.1.2",
     "tsup": "^7.2.0",
-    "typescript": "^5.0.4"
+    "zoralabs-tsconfig": "*",
+    "typescript": "^5.2.2"
   }
 }
diff --git a/packages/1155-contracts/tsconfig.json b/packages/1155-contracts/tsconfig.json
@@ -1,23 +1,7 @@
 {
+  "extends": "zoralabs-tsconfig/tsconfig.json",
   "compilerOptions": {
-    "allowJs": true,
     "baseUrl": ".",
-    "downlevelIteration": true,
-    "esModuleInterop": true,
-    "isolatedModules": true,
-    "lib": ["es2021"],
-    "module": "esnext",
-    "moduleResolution": "node",
-    "noImplicitAny": true,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "strictNullChecks": true,
-    "target": "es2021",
-    "types": ["node"],
     "outDir": "dist"
   },
   "exclude": ["node_modules/**", "dist/**"],
diff --git a/packages/protocol-deployments/package.json b/packages/protocol-deployments/package.json
@@ -39,6 +39,7 @@
     "solady": "^0.0.132",
     "tsup": "^7.2.0",
     "tsx": "^3.13.0",
+    "zoralabs-tsconfig": "*",
     "typescript": "^5.2.2"
   }
 }
diff --git a/packages/protocol-deployments/tsconfig.json b/packages/protocol-deployments/tsconfig.json
@@ -1,23 +1,7 @@
 {
+  "extends": "zoralabs-tsconfig/tsconfig.json",
   "compilerOptions": {
-    "allowJs": true,
     "baseUrl": ".",
-    "downlevelIteration": true,
-    "esModuleInterop": true,
-    "isolatedModules": true,
-    "lib": ["es2021"],
-    "module": "esnext",
-    "moduleResolution": "node",
-    "noImplicitAny": true,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "strictNullChecks": true,
-    "target": "es2021",
-    "types": ["node"],
     "outDir": "dist"
   },
   "exclude": ["node_modules/**", "dist/**"],
diff --git a/packages/protocol-sdk/package.json b/packages/protocol-sdk/package.json
@@ -23,6 +23,7 @@
     "viem": "^1.16.6"
   },
   "devDependencies": {
+    "zoralabs-tsconfig": "*",
     "typescript": "^5.2.2",
     "vite": "4.5.0",
     "vitest": "0.34.6"
diff --git a/packages/protocol-sdk/tsconfig.json b/packages/protocol-sdk/tsconfig.json
@@ -1,23 +1,8 @@
 {
+  "extends": "zoralabs-tsconfig/tsconfig.json",
   "compilerOptions": {
-    "allowJs": true,
-    "baseUrl": ".",
-    "downlevelIteration": true,
-    "esModuleInterop": true,
-    "isolatedModules": true,
     "lib": ["es2021", "DOM"],
-    "module": "esnext",
-    "moduleResolution": "node",
-    "noImplicitAny": true,
-    "noUncheckedIndexedAccess": true,
-    "noUnusedLocals": true,
-    "noUnusedParameters": true,
-    "resolveJsonModule": true,
-    "skipLibCheck": true,
-    "strict": true,
-    "strictNullChecks": true,
-    "target": "es2021",
-    "types": ["node"],
+    "baseUrl": ".",
     "outDir": "dist"
   },
   "exclude": ["node_modules/**", "dist/**"],
diff --git a/packages/tsconfig/package.json b/packages/tsconfig/package.json
@@ -0,0 +1,9 @@
+{
+  "name": "zoralabs-tsconfig",
+  "version": "0.0.0",
+  "private": true,
+  "license": "MIT",
+  "publishConfig": {
+    "access": "public"
+  }
+}
diff --git a/packages/tsconfig/tsconfig.json b/packages/tsconfig/tsconfig.json
@@ -0,0 +1,21 @@
+{
+  "compilerOptions": {
+    "allowJs": true,
+    "downlevelIteration": true,
+    "esModuleInterop": true,
+    "isolatedModules": true,
+    "lib": ["es2021"],
+    "module": "esnext",
+    "moduleResolution": "node",
+    "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "resolveJsonModule": true,
+    "skipLibCheck": true,
+    "strict": true,
+    "strictNullChecks": true,
+    "target": "es2021",
+    "types": ["node"]
+  }
+}
diff --git a/yarn.lock b/yarn.lock
@@ -3994,7 +3994,7 @@ typescript@5.1:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.1.6.tgz#02f8ac202b6dad2c0dd5e0913745b47a37998274"
   integrity sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==
 
-typescript@^5.0.4, typescript@^5.2.2:
+typescript@^5.2.2:
   version "5.2.2"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.2.2.tgz#5ebb5e5a5b75f085f22bc3f8460fba308310fa78"
   integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@`
`53`	`53`	`"prettier-plugin-solidity": "^1.1.3",`
`54`	`54`	`"@types/node": "^20.1.2",`
`55`	`55`	`"tsup": "^7.2.0",`
`56`		`- "typescript": "^5.0.4"`
	`56`	`+ "zoralabs-tsconfig": "*",`
	`57`	`+ "typescript": "^5.2.2"`
`57`	`58`	`}`
`58`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@`
`39`	`39`	`"solady": "^0.0.132",`
`40`	`40`	`"tsup": "^7.2.0",`
`41`	`41`	`"tsx": "^3.13.0",`
	`42`	`+ "zoralabs-tsconfig": "*",`
`42`	`43`	`"typescript": "^5.2.2"`
`43`	`44`	`}`
`44`	`45`	`}`