Make parsing of Bundler dependency output more robust #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
=========================================
Coverage 67.92% 67.92%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7772 7772
Branches 876 876
=========================================
Hits 5279 5279
Misses 2110 2110
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously approved these changes
May 15, 2024
sschuberth
force-pushed
the
bundler-silence-progress
branch
from
5da083a to
212673c
Compare
This is a fixup for 084470a. Signed-off-by: Sebastian Schuberth <[email protected]>
This trivially simplifies an upcoming change. Signed-off-by: Sebastian Schuberth <[email protected]>
When fetching e.g. GitHub dependencies, the console output is slightly different. Instead of adopting the lines to drop, suppress them completely. As now no leading text is printed, the concatenation of printed specs can also be simplified so that it produces no leading null character. Signed-off-by: Sebastian Schuberth <[email protected]>
See [1]. [1]: https://bundler.io/guides/git.html#custom-git-sources Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
bundler-silence-progress
branch
from
212673c to
eed9189
Compare
fviernau
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.