Testing adding a comment to a Gemfile

[lancedikson]

TBD if the test works out
Please ensure that your pull request adheres to our contribution guidelines. Thank you!

[sschuberth]

I guess this PR related to this comment of yours. I ran the same test locally (as that's much faster) and it passes for me.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (43131ad) to head (ec163dd).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #8643   +/-   ##
=========================================
  Coverage     67.92%   67.92%           
  Complexity     1005     1005           
=========================================
  Files           244      244           
  Lines          7772     7772           
  Branches        876      876           
=========================================
  Hits           5279     5279           
  Misses         2110     2110           
  Partials        383      383           

Flag	Coverage Δ
funTest-non-docker	34.79% <ø> (ø)
test	37.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sschuberth]

I guess this PR related to this comment of yours. I ran the same test locally (as that's much faster) and it passes for me.

Interesting, in CI it seems to fail. I'll investigate.

[lancedikson]

I guess this PR related to #7478 (comment) of yours.

Yes, sorry for not linking the PR with the issue proactively

Interesting, in CI it seems to fail. I'll investigate.

Thanks! 🙌 Though the problem is hardly related to the open issue, but most likely to the comment only.

[sschuberth]

Thanks! 🙌 Though the problem is hardly related to the open issue, but most likely to the comment only.

Actually, I can reproduce the problem also without the comment, so it's not related to that (and explains why I could not reproduce the problem by just adding a comment to an existing file). Instead, the problem seems to be related to the github dependency type.

[lancedikson]

Okay, interesting :) It somehow works without a comment for me in my actual project and doesn't work with a comment. That's why I thought it was a comment-related issue.

[sschuberth]

Digging deeper, looks like this is related to Ruby calling native git to fetch from GitHub underneath, and then running into jruby/jruby#6721. Actually, we already apply some of the work-arounds mentioned there. I'll investigate why they seem to have no effect.

[sschuberth]

and then running into jruby/jruby#6721.

That was a red herring. The real cause was slightly different leading console output when fetching from GitHub, and that output was not stripped properly before parsing. #8644 fixes this.

[lancedikson]

Thanks! I'll test it with my project today.