fix(helper-cli): Fix broken reading of scan results by identifier #8613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
helper-cli-fix-create-command
branch
2 times, most recently
from
739e12c to
9944229
Compare
fviernau
force-pushed
the
helper-cli-fix-create-command
branch
from
9944229 to
eb8afcb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8613 +/- ##
=========================================
Coverage 67.97% 67.97%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7844 7844
Branches 876 876
=========================================
Hits 5332 5332
Misses 2129 2129
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Commit message: Typo in "provnenance". |
tsteenbe
reviewed
May 3, 2024
The refactoring done in [1] does not just merge functions, but in addition changes the behavior of the `read()` function to filter the result by the provenance of the given package. So, [1] obviously broke the reading of scan results in `helper-cli`'s `CreateCommand`, see also [2][3]. A better way to fix this might be to migrate the command to use a scan results by provenance storage together with a package / nested provenance storage. As this is a bigger effort, fix the regression from [1] for now in a rather minimal invasive way, which just bypasses the filtering by provenance. [1]: 70b1b86 [2]: https://github.com/oss-review-toolkit/ort/blob/8ed8e2bff913f1d3aafecfb6eb746614f01dfafc/helper-cli/src/main/kotlin/commands/packageconfig/CreateCommand.kt#L123 [3]: https://github.com/oss-review-toolkit/ort/blob/8ed8e2bff913f1d3aafecfb6eb746614f01dfafc/scanner/src/main/kotlin/storages/PackageBasedFileStorage.kt#L75 Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
helper-cli-fix-create-command
branch
from
eb8afcb to
c13ff80
Compare
mnonnenmacher
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.