fix(helper-cli): Fix broken reading of scan results by identifier

The refactoring done in [1] does not just merges functions, but in
addition changes the behavior of the `read()` function to filter the
result by the provenance of the given package. So, [1] obviously broke
the reading of scan results in `helper-cli`'s `CreateCommand`, see also
[2][3].

A better way to fix this might be to migrate the command to use
a scan results by provenance storage together with a package / nested
provenance storage. As this is a bigger effort, fix the regression from
[1] for now in a rather minimal invasive way, which just bypasses the
filtering by provnenance.

[1]: 70b1b86
[2]: https://github.com/oss-review-toolkit/ort/blob/8ed8e2bff913f1d3aafecfb6eb746614f01dfafc/helper-cli/src/main/kotlin/commands/packageconfig/CreateCommand.kt#L123
[3]: https://github.com/oss-review-toolkit/ort/blob/8ed8e2bff913f1d3aafecfb6eb746614f01dfafc/scanner/src/main/kotlin/storages/PackageBasedFileStorage.kt#L75

Signed-off-by: Frank Viernau <[email protected]>

helper-cli/src/main/kotlin/commands/packageconfig/CreateCommand.kt

@@ -36,7 +36,6 @@ import org.ossreviewtoolkit.helper.utils.sortPathExcludes
 import org.ossreviewtoolkit.helper.utils.write
 import org.ossreviewtoolkit.model.ArtifactProvenance
 import org.ossreviewtoolkit.model.Identifier
-import org.ossreviewtoolkit.model.Package
 import org.ossreviewtoolkit.model.RepositoryProvenance
 import org.ossreviewtoolkit.model.ScanResult
 import org.ossreviewtoolkit.model.config.PackageConfiguration
@@ -120,7 +119,7 @@ internal class CreateCommand : CliktCommand(
         outputDir.safeMkdirs()
 
         val scanResultsStorage = PackageBasedFileStorage(LocalFileStorage(scanResultsStorageDir))
-        val scanResults = scanResultsStorage.read(Package.EMPTY.copy(id = packageId)).getOrThrow().run {
+        val scanResults = scanResultsStorage.readForId(id = packageId).getOrThrow().run {
             listOfNotNull(
                 find { it.provenance is RepositoryProvenance },
                 find { it.provenance is ArtifactProvenance }

scanner/src/main/kotlin/storages/PackageBasedFileStorage.kt

@@ -51,7 +51,7 @@ class PackageBasedFileStorage(
 ) : AbstractPackageBasedScanStorage() {
     override val name = "${javaClass.simpleName} with ${backend.javaClass.simpleName} backend"
 
-    private fun readForId(id: Identifier): Result<List<ScanResult>> {
+    fun readForId(id: Identifier): Result<List<ScanResult>> {
         val path = storagePath(id)
 
         return runCatching {