-
Notifications
You must be signed in to change notification settings - Fork 50
Add ignore validation flag while registering model & improve logging #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrDzurb
reviewed
Dec 14, 2024
darenr
previously approved these changes
Jan 5, 2025
mrDzurb
approved these changes
Jan 31, 2025
mayoor
approved these changes
Feb 1, 2025
mayoor
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mistral has released some of their models in the Mistral format where you get one consolidated.safetensors and a params.json , and there is no config.json file. We still want users to proceed with model registration since the current set up restricts user to proceed.
This PR adds a input check
--ignore-model-artifact-check
that will not throw an error during registration whenconfig.json
is not in the model artifacts.Also, some improvements have been made:
.safetensors
file names along with config.json. This ensures that the model file list is not empty when config.json is not present. This applies to files read both from Object Storage and HF repo.In addition to this:
This PR adds additional logging statements in the CRUD operations for model, deployment, finetuning and evaluation operations in AI Quick Actions. In addition to this, the PR also covers the following:
Jira
More details on testing are in the ticket:
ODSC-65657
Testing
Register via HuggingFace
Scenario 1: Model has config.json file, user can proceed with registration.
Scenario 2: Model has no config.json, but is supported by vLLM. Validation does not allow registration to proceed.
Scenario 3: Model has no config.json, but with
--ignore_model_artifact_check True
parameter can proceed with registration.Register via Object Storage
Scenario 4: Model comes from OSS and the path is correct. Validation says that there is no config.json file.
Scenario 5: Model comes from OSS and the path is correct, and we use the override flag. Registration is allowed to proceed.