-
Notifications
You must be signed in to change notification settings - Fork 50
Additional logging statements for AI Quick Actions operations #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional logging statements for AI Quick Actions operations #1034
Conversation
…le/accelerated-data-science into ODSC-65657/ignore_config_validation
…le/accelerated-data-science into ODSC-65657/ignore_config_validation
@@ -1159,3 +1164,49 @@ def validate_cmd_var(cmd_var: List[str], overrides: List[str]) -> List[str]: | |||
|
|||
combined_cmd_var = cmd_var + overrides | |||
return combined_cmd_var | |||
|
|||
|
|||
def validate_dataclass_params(dataclass_type: Type[T], **kwargs: Any) -> Optional[T]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there is some built-in solution to do this. It would be so easy to do with pydantic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the error validation here covers both dataclass and pydantic's basemodel since we use both in aqua. We can simplify this once all dataclasses are updated to use pydantic.
8db09df
into
ODSC-65657/ignore_config_validation
Description
This PR adds additional logging statements in the CRUD operations for model, deployment, finetuning and evaluation operations in AI Quick Actions. In addition to this, the PR also covers the following:
This is built on top of #1023 and will be followed up by another PR to update error handler decorator, and apply it at the aqua function level instead of handler level to capture and log aqua CLI errors as well.
Tests