-
Notifications
You must be signed in to change notification settings - Fork 68
feat: E2 supports suspension & VmExecState supports clone #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5f43a22
to
5aa85d1
Compare
5aa85d1
to
04ccc72
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small comments
a general comment not for this pr is that we should try to make some of these config parameters const generic in the future to avoid runtime overhead
Actually we use |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. just add a note that the VmExecState
returned by execute_metered_from_state_until_suspension
is not at segment boundary but something slightly beyond that
This comment has been minimized.
This comment has been minimized.
b055827
to
34ba555
Compare
Commit: 34ba555 |
VmExecState
/VmState
supports clone. Benchmark shows cloning a VM state which only uses address space 2 takes 0.3~0.6ms.closes INT-5066
closes INT-5067