Skip to content

Conversation

nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented Sep 16, 2025

  • E2 execution supports suspension every segment. Reth-benchmark doesn't show performance difference.
  • VmExecState/VmState supports clone. Benchmark shows cloning a VM state which only uses address space 2 takes 0.3~0.6ms.

closes INT-5066
closes INT-5067

This comment has been minimized.

@nyunyunyunyu nyunyunyunyu changed the title feat: E2 supports suspension feat: E2 supports suspension & VmExecState supports clone Sep 17, 2025

This comment has been minimized.

@nyunyunyunyu nyunyunyunyu marked this pull request as ready for review September 17, 2025 01:13
Copy link
Contributor

@shuklaayush shuklaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments
a general comment not for this pr is that we should try to make some of these config parameters const generic in the future to avoid runtime overhead

@nyunyunyunyu
Copy link
Contributor Author

some small comments a general comment not for this pr is that we should try to make some of these config parameters const generic in the future to avoid runtime overhead

Actually we use MeteredCtx everywhere and all the places don't really use PAGE_BITS as a generic. I tried it but it touches too many places so I think we probably should change this later.

This comment has been minimized.

Copy link
Contributor

@shuklaayush shuklaayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just add a note that the VmExecState returned by execute_metered_from_state_until_suspension is not at segment boundary but something slightly beyond that

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-6 [-2.2%]) 266 322,610 2,058,654 - - -
fibonacci (+4 [+0.3%]) 1,219 1,500,210 2,107,962 - - -
regex (+90 [+3.0%]) 3,051 4,108,483 17,662,886 - - -
ecrecover (-16 [-1.8%]) 872 140,497 2,275,056 - - -
pairing (+10 [+0.6%]) 1,775 1,882,939 25,847,762 - - -

Commit: 34ba555

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants