feat: check for segmentation after each keccak/sha instruction #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We don't use this result, so for most CTX implementations this does nothing. | ||
| // However, for MeteredCtx this forces a segment check since its implementation | ||
| // of should_suspend performs one as a side effect. | ||
| CTX::should_suspend(*instret, *pc, 0, exec_state); |
There was a problem hiding this comment.
Note we pass 0 to segment_check_insns here, since MeteredCtx will skip the check if instret < segment_check_insns + last_segment_check. This should always force a segment check assuming instret increases monotonically.
Commit: ff32fef |
shuklaayush
reviewed
Sep 17, 2025
Comment on lines
+174
to
+177
| // We don't use this result, so for most CTX implementations this does nothing. | ||
| // However, for MeteredCtx this forces a segment check since its implementation | ||
| // of should_suspend performs one as a side effect. | ||
| CTX::should_suspend(*instret, *pc, 0, exec_state); |
There was a problem hiding this comment.
this conflicts with #2140 so we need to think of a way to both check for segmentation and suspend if segmented (i.e. can't discard the result)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves INT-5063. Benchmark run shows no difference https://github.com/axiom-crypto/openvm-reth-benchmark/actions/runs/17804008078