Increaset job timeout for openshift-sandboxed-containers workflows #71161
Conversation
| - chain: sandboxed-containers-operator-pre | ||
| post: | ||
| - ref: sandboxed-containers-operator-gather-must-gather | ||
| - ref: cucushift-installer-wait |
tbuskey
left a comment
tbuskey
left a comment
There was a problem hiding this comment.
Can the changes be added to sandboxed-containers-operator-create-prowjob-commands.sh
We should move to generating openshift-sandboxed-containers-operator-devel__downstream-candidate.yaml and openshift-sandboxed-containers-operator-devel__downstream-release.yaml with the script. Also 4.17-4.20 versions
| - chain: sandboxed-containers-operator-pre | ||
| post: | ||
| - ref: sandboxed-containers-operator-gather-must-gather | ||
| - ref: cucushift-installer-wait |
we're hitting 4h timeout when running manual suite via cucushift-installer-wait. Increase the default timeout to 24h Signed-off-by: Lukáš Doktor <[email protected]>
in case cucushift-installer-wait fails the consequent cleanup steps are not executed and the cloud cleanup is not performed, leaving resources behind. Move it to test-phase ensures the cleanup should be executed. There is one drawback, failed "e2e" execution results in skipped cucushift-installer-wait. This shouldn't be often a problem as we only fail on infra error, not on test fail. Signed-off-by: Lukáš Doktor <[email protected]>
we only want to allow 12h reservation. Signed-off-by: Lukáš Doktor <[email protected]>
|
Changes:
|
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldoktor, tbuskey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Since there is a consensus that it should be merged, let me add the rehearsal ack and update the dependant PR... /pj-rehearse ack |
|
@ldoktor: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@ldoktor: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…penshift#71161) * ci-operator.config.osc: Increase job timeout we're hitting 4h timeout when running manual suite via cucushift-installer-wait. Increase the default timeout to 24h Signed-off-by: Lukáš Doktor <[email protected]> * ci-operator.step: Move cucushift-installer-wait to test phase in case cucushift-installer-wait fails the consequent cleanup steps are not executed and the cloud cleanup is not performed, leaving resources behind. Move it to test-phase ensures the cleanup should be executed. There is one drawback, failed "e2e" execution results in skipped cucushift-installer-wait. This shouldn't be often a problem as we only fail on infra error, not on test fail. Signed-off-by: Lukáš Doktor <[email protected]> * ci-operator.step: Limit cucushift-installer-wait to 12h we only want to allow 12h reservation. Signed-off-by: Lukáš Doktor <[email protected]> --------- Signed-off-by: Lukáš Doktor <[email protected]>
4 participants
when testing manually we are hitting the 4h timeout. Let's increase the timeout to allow longer execution and move the cucushift-installer-wait to test phase to avoid interrupting the cleanup.
As suggested by on slack this probably needs to be merged before the
timeoutis used.