Increaset job timeout for openshift-sandboxed-containers workflows (#71161)

* ci-operator.config.osc: Increase job timeout

we're hitting 4h timeout when running manual suite via
cucushift-installer-wait. Increase the default timeout to 24h

Signed-off-by: Lukáš Doktor <[email protected]>

* ci-operator.step: Move cucushift-installer-wait to test phase

in case cucushift-installer-wait fails the consequent cleanup steps are
not executed and the cloud cleanup is not performed, leaving resources
behind. Move it to test-phase ensures the cleanup should be executed.

There is one drawback, failed "e2e" execution results in skipped
cucushift-installer-wait. This shouldn't be often a problem as we only
fail on infra error, not on test fail.

Signed-off-by: Lukáš Doktor <[email protected]>

* ci-operator.step: Limit cucushift-installer-wait to 12h

we only want to allow 12h reservation.

Signed-off-by: Lukáš Doktor <[email protected]>

---------

Signed-off-by: Lukáš Doktor <[email protected]>

Author: ldoktor

ci-operator/config/openshift/sandboxed-containers-operator/openshift-sandboxed-containers-operator-devel__downstream-candidate.yaml

@@ -38,6 +38,7 @@ tests:
       TEST_SCENARIOS: sig-kata.*Kata Author
       TEST_TIMEOUT: "75"
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -58,6 +59,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -82,6 +84,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: trustee-catalog
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: aws-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -104,6 +107,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 - as: aws-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -128,6 +132,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: trustee-catalog
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 zz_generated_metadata:
   branch: devel
   org: openshift

ci-operator/config/openshift/sandboxed-containers-operator/openshift-sandboxed-containers-operator-devel__downstream-release.yaml

@@ -34,6 +34,7 @@ tests:
       TEST_SCENARIOS: sig-kata.*Kata Author
       TEST_TIMEOUT: "75"
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -52,6 +53,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -70,6 +72,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: aws-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -88,6 +91,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 - as: aws-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -106,6 +110,7 @@ tests:
       TEST_TIMEOUT: "75"
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 zz_generated_metadata:
   branch: devel
   org: openshift

ci-operator/step-registry/sandboxed-containers-operator/create-prowjob/sandboxed-containers-operator-create-prowjob-commands.sh

@@ -387,6 +387,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_IMAGE: ${TRUSTEE_CATALOG_SOURCE_IMAGE}
       TRUSTEE_CATALOG_SOURCE_NAME: ${TRUSTEE_CATALOG_SOURCE_NAME}
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -413,6 +414,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: ${TRUSTEE_CATALOG_SOURCE_NAME}
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: azure-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -439,6 +441,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: ${TRUSTEE_CATALOG_SOURCE_NAME}
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-azure
+  timeout: 24h0m0s
 - as: aws-ipi-peerpods
   cron: 0 0 31 2 1
   steps:
@@ -464,6 +467,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: ${TRUSTEE_CATALOG_SOURCE_NAME}
       WORKLOAD_TO_TEST: peer-pods
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 - as: aws-ipi-coco
   cron: 0 0 31 2 1
   steps:
@@ -489,6 +493,7 @@ tests:
       TRUSTEE_CATALOG_SOURCE_NAME: ${TRUSTEE_CATALOG_SOURCE_NAME}
       WORKLOAD_TO_TEST: coco
     workflow: sandboxed-containers-operator-e2e-aws
+  timeout: 24h0m0s
 zz_generated_metadata:
   branch: devel
   org: openshift

ci-operator/step-registry/sandboxed-containers-operator/e2e/aws/sandboxed-containers-operator-e2e-aws-workflow.yaml

@@ -21,11 +21,12 @@ workflow:
     - chain: sandboxed-containers-operator-pre
     post:
     - ref: sandboxed-containers-operator-gather-must-gather
-    - ref: cucushift-installer-wait
     - ref: sandboxed-containers-operator-post
     - chain: ipi-aws-post
     test:
     - ref: openshift-extended-test
+    - ref: cucushift-installer-wait
+      timeout: 12h10m0s
   documentation: |-
     This workflow run openshift-extented-test on an AWS cluster with
     the sandboxed containers deployed.

ci-operator/step-registry/sandboxed-containers-operator/e2e/azure/sandboxed-containers-operator-e2e-azure-workflow.yaml

@@ -14,10 +14,11 @@ workflow:
     - chain: sandboxed-containers-operator-pre
     post:
     - ref: sandboxed-containers-operator-gather-must-gather
-    - ref: cucushift-installer-wait
     - chain: ipi-azure-post
     test:
     - ref: openshift-extended-test
+    - ref: cucushift-installer-wait
+      timeout: 12h10m0s
   documentation: |-
     This workflow run openshift-extented-test on an Azure cluster with
     the sandboxed containers deployed.