-
Notifications
You must be signed in to change notification settings - Fork 657
OCPBUGS-56629: use EmptyState for quick starts empty state #15081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 2 commits into
openshift:main
from
logonoff:OCPBUGS-56629-quick-starts
Jun 13, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
frontend/packages/console-app/src/components/quick-starts/QuickStartEmptyState.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import { | ||
| Button, | ||
| EmptyState, | ||
| EmptyStateBody, | ||
| EmptyStateActions, | ||
| EmptyStateFooter, | ||
| EmptyStateVariant, | ||
| Skeleton, | ||
| } from '@patternfly/react-core'; | ||
| import { CubesIcon } from '@patternfly/react-icons/dist/esm/icons/cubes-icon'; | ||
| import { ExternalLinkAltIcon } from '@patternfly/react-icons/dist/esm/icons/external-link-alt-icon'; | ||
| import { WrenchIcon } from '@patternfly/react-icons/dist/esm/icons/wrench-icon'; | ||
| import { useTranslation } from 'react-i18next'; | ||
| import { QuickStartModel } from '@console/app/src/models'; | ||
| import { useAccessReview } from '@console/dynamic-plugin-sdk/src/app/components/utils/rbac'; | ||
| import { getReferenceForModel } from '@console/dynamic-plugin-sdk/src/utils/k8s'; | ||
| import { | ||
| documentationURLs, | ||
| getDocumentationURL, | ||
| } from '@console/internal/components/utils/documentation'; | ||
| import { LinkTo } from '@console/shared/src/components/links/LinkTo'; | ||
|
|
||
| export const QuickStartEmptyState = () => { | ||
| const { t } = useTranslation('console-app'); | ||
|
|
||
| const [canAddQuickStarts, loading] = useAccessReview({ | ||
| group: QuickStartModel.apiGroup, | ||
| resource: QuickStartModel.kind, | ||
| verb: 'create', | ||
| }); | ||
|
|
||
| return ( | ||
| <EmptyState | ||
| titleText={t('No {{label}} found', { label: QuickStartModel.labelPlural })} | ||
| headingLevel="h4" | ||
| icon={loading ? Skeleton : canAddQuickStarts ? WrenchIcon : CubesIcon} | ||
| variant={EmptyStateVariant.lg} | ||
| > | ||
| {!loading ? ( | ||
| <> | ||
| <EmptyStateBody> | ||
| {canAddQuickStarts | ||
| ? t('Configure quick starts to help users get started with the cluster.') | ||
| : t('Ask a cluster administrator to configure quick starts.')} | ||
| </EmptyStateBody> | ||
| {canAddQuickStarts && ( | ||
| <EmptyStateFooter> | ||
| <EmptyStateActions> | ||
| <Button | ||
| variant="primary" | ||
| component={LinkTo('/cluster-configuration#quick-starts-configuration')} | ||
| > | ||
| {t('Configure quick starts')} | ||
| </Button> | ||
| </EmptyStateActions> | ||
| <EmptyStateActions> | ||
| <Button | ||
| variant="link" | ||
| component={LinkTo(`/k8s/cluster/${getReferenceForModel(QuickStartModel)}/~new`)} | ||
| > | ||
| {t('Create {{kind}}', { kind: QuickStartModel.kind })} | ||
| </Button> | ||
| <Button | ||
| variant="link" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| component="a" | ||
| href={getDocumentationURL(documentationURLs.creatingQuickStartsTutorial)} | ||
| iconPosition="right" | ||
| icon={<ExternalLinkAltIcon />} | ||
| > | ||
| {t('Learn more about quick starts')} | ||
| </Button> | ||
| </EmptyStateActions> | ||
| </EmptyStateFooter> | ||
| )} | ||
| </> | ||
| ) : ( | ||
| <EmptyStateBody> | ||
| <Skeleton /> | ||
| </EmptyStateBody> | ||
| )} | ||
| </EmptyState> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this the first time. Use
<ExternalLink>instead? We have had a proliferation oftarget="_blank"for some reason...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExternalLinkdoesn't look right when used as part of acomponentfor a PFButton... I could make anExternalLinkButtoncomponent as part of this PR insteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM. DRYing it up is the goal. 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna defer to the DRYing work to a separate PR.
/lgtm