Skip to content

OCPBUGS-56629: use EmptyState for quick starts empty state #15081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-56629: use EmptyState for quick starts empty state #15081

wants to merge 2 commits into from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented May 22, 2025 •
edited
Loading

fixes https://issues.redhat.com/browse/OCPBUGS-56629

before:

after (non-admin user):

after (admin user):

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-56629, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-56629

before:

after (non-admin user):

after (admin user):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 22, 2025
@openshift-ci openshift-ci bot requested review from yapei, cajieh and Lucifergene May 22, 2025 20:31
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 22, 2025
@logonoff logonoff force-pushed the OCPBUGS-56629-quick-starts branch from 65103e5 to 92562a7 Compare May 22, 2025 20:36
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-56629, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

fixes https://issues.redhat.com/browse/OCPBUGS-56629

before:

after (non-admin user):

after (admin user):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the OCPBUGS-56629-quick-starts branch from 92562a7 to 0083d0d Compare May 28, 2025 19:45
@logonoff
Copy link
Member Author

ux review:
/assign @kevinhatchoua

code review:
/assign @rhamilto

rhamilto
rhamilto reviewed May 29, 2025
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few recommended tweaks.

@logonoff logonoff force-pushed the OCPBUGS-56629-quick-starts branch from 0083d0d to c98bcd4 Compare May 29, 2025 12:33
@logonoff logonoff requested a review from rhamilto May 29, 2025 12:33
@logonoff logonoff force-pushed the OCPBUGS-56629-quick-starts branch from c98bcd4 to 4c621e3 Compare May 29, 2025 12:35
@logonoff logonoff force-pushed the OCPBUGS-56629-quick-starts branch from 4c621e3 to 780f31b Compare May 29, 2025 12:41
rhamilto
rhamilto approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 71dd5f8 and 2 for PR HEAD 780f31b in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 71dd5f8 and 2 for PR HEAD 780f31b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5342f47 and 1 for PR HEAD 780f31b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 780f31b link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5342f47 and 2 for PR HEAD 780f31b in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@yapei yapei Awaiting requested review from yapei

@cajieh cajieh Awaiting requested review from cajieh

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

Assignees

@rhamilto rhamilto

@kevinhatchoua kevinhatchoua

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@logonoff @openshift-ci-robot @rhamilto @kevinhatchoua