OCPBUGS-54780: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace #978

TheRealJon · 2025-04-10T15:20:48Z

No description provided.

openshift-ci-robot · 2025-04-10T15:20:55Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-54780, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-04-10T15:21:14Z

/hold

Wait for #963

TheRealJon · 2025-04-11T14:45:31Z

/jira refresh

openshift-ci-robot · 2025-04-11T14:45:41Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-54780, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-04-21T14:05:15Z

/retest

…onfigmaps in openshift-console namespace

TheRealJon · 2025-04-24T15:21:59Z

/hold cancel

pkg/console/operator/sync_v400.go

jhadvig · 2025-04-24T15:53:45Z

pkg/console/operator/sync_v400.go

+	klog.V(4).Infof("%#v", configMapNames)
+
+	errors := []string{}
+	if len(co.trackables.customLogoConfigMaps) > 0 {


this does not seem to be right,cause we will be unsyncing on each sync loop run, except the first one, which will set the trackables

Yeah this was intentional. On every sync loop we:

unsync all configmaps from the previous loop

resync all configmaps for the current loop

set trackables.customLogoConfigMaps to configmaps from current loop

This means that if the list of configmaps for the previous loop and the current loop are the same, the net result is that we just continue syncing the same configmaps.

pkg/console/operator/sync_v400.go

jhadvig · 2025-04-28T16:23:13Z

/lgtm
/override ci/prow/e2e-aws-console ci/prow/okd-scos-e2e-aws-ovn

openshift-ci · 2025-04-28T16:23:57Z

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console, ci/prow/okd-scos-e2e-aws-ovn

In response to this:

/lgtm
/override ci/prow/e2e-aws-console ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-05-02T07:25:07Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2025-05-02T07:25:56Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-54780, which is invalid:

expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-05-02T15:24:25Z

/jira refresh
/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-05-02T15:24:28Z

@TheRealJon: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/jira refresh
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-05-02T15:24:30Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-54780, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-05-02T15:25:11Z

/label tide/merge-method-squash

jhadvig · 2025-05-05T14:01:58Z

/lgtm

openshift-ci · 2025-05-05T14:02:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [TheRealJon,jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jhadvig · 2025-05-05T14:02:33Z

Overriding the flaking OVN test
/override ci/prow/okd-scos-e2e-aws-ovn

openshift-ci · 2025-05-05T14:03:08Z

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/okd-scos-e2e-aws-ovn

In response to this:

Overriding the flaking OVN test
/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-05-05T14:03:09Z

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-05-05T15:24:11Z

@TheRealJon: Jira Issue OCPBUGS-54780: All pull requests linked via external trackers have merged:

openshift/console-operator#978

Jira Issue OCPBUGS-54780 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-05-05T15:25:03Z

@TheRealJon: new pull request created: #985

In response to this:

/jira refresh
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-05-05T17:57:50Z

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.20.0-202505051711.p0.g183e7e5.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Apr 10, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 10, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2025

TheRealJon marked this pull request as draft April 10, 2025 15:21

openshift-ci bot requested review from jhadvig and spadgett April 10, 2025 15:22

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025

TheRealJon force-pushed the OCPBUGS-54780 branch from f549608 to 828381a Compare April 10, 2025 22:05

TheRealJon changed the title ~~[WIP] OCPBUGS-54780: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace~~ OCPBUGS-54780: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace Apr 10, 2025

TheRealJon force-pushed the OCPBUGS-54780 branch from 828381a to 40e1f03 Compare April 11, 2025 13:59

TheRealJon marked this pull request as ready for review April 11, 2025 14:38

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2025

openshift-ci bot requested a review from yapei April 11, 2025 14:45

TheRealJon mentioned this pull request Apr 15, 2025

OCPBUGS-53412,CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API #963

Merged

TheRealJon force-pushed the OCPBUGS-54780 branch from 40e1f03 to bb18d11 Compare April 15, 2025 15:21

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2025

OCPBUGS-54780: Fix issue where console operator orphans custom logo c…

ab68bff

…onfigmaps in openshift-console namespace

TheRealJon force-pushed the OCPBUGS-54780 branch from bb18d11 to ab68bff Compare April 24, 2025 15:21

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025

jhadvig reviewed Apr 24, 2025

View reviewed changes

openshift-ci bot assigned jhadvig Apr 28, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2025

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 2, 2025

improve debug logs for custom logo sync

920e476

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 2, 2025

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 2, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025

openshift-merge-bot bot merged commit 183e7e5 into openshift:main May 5, 2025
13 checks passed

openshift-cherrypick-robot mentioned this pull request May 5, 2025

[release-4.19] OCPBUGS-55716: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace #985

Merged

TheRealJon deleted the OCPBUGS-54780 branch May 5, 2025 15:31

OCPBUGS-54780: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace #978

OCPBUGS-54780: Fix issue where console operator orphans custom logo configmaps in openshift-console namespace #978

Uh oh!

Conversation

TheRealJon commented Apr 10, 2025

Uh oh!

openshift-ci-robot commented Apr 10, 2025

Uh oh!

TheRealJon commented Apr 10, 2025

Uh oh!

TheRealJon commented Apr 11, 2025

Uh oh!

openshift-ci-robot commented Apr 11, 2025

Uh oh!

TheRealJon commented Apr 21, 2025

Uh oh!

TheRealJon commented Apr 24, 2025

Uh oh!

Uh oh!

jhadvig Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

TheRealJon May 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhadvig commented Apr 28, 2025

Uh oh!

openshift-ci bot commented Apr 28, 2025

Uh oh!

openshift-bot commented May 2, 2025

Uh oh!

openshift-ci-robot commented May 2, 2025

Uh oh!

TheRealJon commented May 2, 2025

Uh oh!

openshift-cherrypick-robot commented May 2, 2025

Uh oh!

openshift-ci-robot commented May 2, 2025

Uh oh!

TheRealJon commented May 2, 2025

Uh oh!

jhadvig commented May 5, 2025

Uh oh!

openshift-ci bot commented May 5, 2025

Uh oh!

jhadvig commented May 5, 2025

Uh oh!

openshift-ci bot commented May 5, 2025

Uh oh!

openshift-ci bot commented May 5, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented May 5, 2025

Uh oh!

openshift-cherrypick-robot commented May 5, 2025

Uh oh!

openshift-bot commented May 5, 2025

Uh oh!

Uh oh!