Skip to content

OCPBUGS-53412,CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 24, 2025

  • Update custom logo sync to come before console config and deployment syncs
  • custom logo sync returns on failure, no need for "ok to mount" conditions when building console config and deployments
  • Remove extra custom logo related args from deployment and console config sync functions. Use existing console operator config.
  • Add SyncCustomLogos function to validate and sync configmaps defined by new API
  • Update SyncCustomLogoConfigMap to remove bool return value
  • Share UpdateCustomLogoSyncSource between SyncCustomLogos and SyncCustomLogoConfigMap
  • Update DefaultConfigMap func to handle new API
  • Update config builder to convert old API to new, and sync either new API or converted old API to console config
  • Update DefaultDeployment to create appropriate volumes depending on CustomLogoFile or Logos
  • Update unit and e2e tests

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2025

@TheRealJon: This pull request references CONSOLE-4061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon TheRealJon changed the title [WIP] CONSOLE-4061: Update console operator to support new custom log API [WIP] CONSOLE-4061: Update console operator to support new custom logos API Feb 24, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett February 24, 2025 18:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2025
@TheRealJon
Copy link
Member Author

/hold

Depends on openshift/api#2177

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@TheRealJon TheRealJon force-pushed the CONSOLE-4061 branch 2 times, most recently from 2877f48 to 153f47b Compare March 20, 2025 19:02
@TheRealJon TheRealJon changed the title [WIP] CONSOLE-4061: Update console operator to support new custom logos API CONSOLE-4061: Update console operator to support new custom logos API Mar 21, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@TheRealJon TheRealJon changed the title CONSOLE-4061: Update console operator to support new custom logos API CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API Apr 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@TheRealJon: This pull request references CONSOLE-4479 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references CONSOLE-4061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon TheRealJon force-pushed the CONSOLE-4061 branch 2 times, most recently from 1dcbda4 to 6a61390 Compare April 2, 2025 18:27
@TheRealJon
Copy link
Member Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 7, 2025

INFO[2025-04-04T20:36:43Z] KUBERNETES_CONFIG=/tmp/kubeconfig-441242176 go test -timeout 30m -v ./test/e2e/
checking for console-operator availability
found operator deployment
=== RUN   TestOperatorConfigBranding
    brand_builtins_test.go:78: update operator with okd
    brand_builtins_test.go:78: update operator with ocp
    brand_builtins_test.go:78: update operator with online
    brand_builtins_test.go:78: update operator with dedicated
    brand_builtins_test.go:78: update operator with azure
    brand_builtins_test.go:78: update operator with OKD
    brand_builtins_test.go:78: update operator with OCP
    brand_builtins_test.go:78: update operator with Online
    brand_builtins_test.go:78: update operator with Dedicated
    brand_builtins_test.go:78: update operator with Azure
    brand_builtins_test.go:78: update operator with ROSA
    brand_builtins_test.go:61: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- PASS: TestOperatorConfigBranding (66.26s)
=== RUN   TestBrandingFromManagedConfigMap
    brand_builtins_test.go:106: update data for the config map in openshift-config-managed namespace with okd
    brand_builtins_test.go:106: update data for the config map in openshift-config-managed namespace with ocp
    brand_builtins_test.go:61: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- PASS: TestBrandingFromManagedConfigMap (37.29s)
=== RUN   TestCustomBrand
    brand_customization_test.go:43: waiting for setup to reach settled state...
    brand_customization_test.go:138: setting custom-product-name and custom-logo in "png" format
    brand_customization_test.go:103: error: configmap custom-logo not found in openshift-console
    brand_customization_test.go:52: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- FAIL: TestCustomBrand (72.47s)
=== RUN   TestIngressConsoleComponentRoute
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- PASS: TestIngressConsoleComponentRoute (27.54s)
=== RUN   TestIngressConsoleComponentRouteWithTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestIngressConsoleComponentRouteWithTLS (16.[76](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_console-operator/963/pull-ci-openshift-console-operator-main-e2e-aws-operator/1908236770810531840#1:build-log.txt%3A76)s)
=== RUN   TestIngressConsoleComponentRouteWithCustomTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:414: error: failed to verify custom certificate PEM: custom TLS certificate is expired
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestIngressConsoleComponentRouteWithCustomTLS (6.50s)
=== RUN   TestIngressDownloadsComponentRoute
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "downloads" to "downloads-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- PASS: TestIngressDownloadsComponentRoute (7.53s)
=== RUN   TestIngressDownloadsComponentRouteWithTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "downloads" to "downloads-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestIngressDownloadsComponentRouteWithTLS (17.01s)
=== RUN   TestIngressConsoleAndDownloadsComponentRoute
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:526: setting custom URL on ingress config for "downloads" to "downloads-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- PASS: TestIngressConsoleAndDownloadsComponentRoute (41.[87](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_console-operator/963/pull-ci-openshift-console-operator-main-e2e-aws-operator/1908236770810531840#1:build-log.txt%3A87)s)
=== RUN   TestIngressConsoleAndDownloadsComponentRouteWithTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:526: setting custom URL on ingress config for "downloads" to "downloads-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestIngressConsoleAndDownloadsComponentRouteWithTLS (28.34s)
=== RUN   TestLegacyCustomURL
    custom_url_test.go:[91](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_console-operator/963/pull-ci-openshift-console-operator-main-e2e-aws-operator/1908236770810531840#1:build-log.txt%3A91): waiting for setup to reach settled state...
    custom_url_test.go:507: setting custom URL on console-operator config to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
    console-operator.go:375: waited 10 seconds to reach settled state...
--- PASS: TestLegacyCustomURL (41.75s)
=== RUN   TestLegacyCustomURLWithTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:507: setting custom URL on console-operator config to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:[107](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_console-operator/963/pull-ci-openshift-console-operator-main-e2e-aws-operator/1908236770810531840#1:build-log.txt%3A107): waiting for cleanup to reach settled state...
--- FAIL: TestLegacyCustomURLWithTLS (17.02s)
=== RUN   TestLegacyConsoleComponentRouteWithCustomTLS
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:507: setting custom URL on console-operator config to "console-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:414: error: failed to verify custom certificate PEM: custom TLS certificate is expired
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestLegacyConsoleComponentRouteWithCustomTLS (6.73s)
=== RUN   TestLegacyCustomURLWithIngressConsoleComponentRoute
    custom_url_test.go:91: waiting for setup to reach settled state...
    custom_url_test.go:507: setting custom URL on console-operator config to "console-custom-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:526: setting custom URL on ingress config for "console" to "console-custom-ingress-openshift-console.apps.ci-op-tlqf1k9l-7ab6c.origin-ci-int-aws.dev.rhcloud.com"
    custom_url_test.go:370: error: timed out waiting for the condition
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:570: unsetting custom URL
    custom_url_test.go:545: unsetting ingress config's component routes
    custom_url_test.go:107: waiting for cleanup to reach settled state...
--- FAIL: TestLegacyCustomURLWithIngressConsoleComponentRoute (18.66s)

@jhadvig
Copy link
Member

jhadvig commented Apr 7, 2025

/retest

@TheRealJon
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 8, 2025
@yanpzhan
Copy link

There is not blocking issue for current feature, we can discuss any confusion later, so approve the pr now.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 22, 2025

@TheRealJon: This pull request references CONSOLE-4479 which is a valid jira issue.

This pull request references CONSOLE-4061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Update custom logo sync to come before console config and deployment syncs
  • custom logo sync returns on failure, no need for "ok to mount" conditions when building console config and deployments
  • Remove extra custom logo related args from deployment and console config sync functions. Use existing console operator config.
  • Add SyncCustomLogos function to validate and sync configmaps defined by new API
  • Update SyncCustomLogoConfigMap to remove bool return value
  • Share UpdateCustomLogoSyncSource between SyncCustomLogos and SyncCustomLogoConfigMap
  • Update DefaultConfigMap func to handle new API
  • Update config builder to convert old API to new, and sync either new API or converted old API to console config
  • Update DefaultDeployment to create appropriate volumes depending on CustomLogoFile or Logos
  • Update unit and e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 22, 2025
@opayne1
Copy link

opayne1 commented Apr 22, 2025

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e7945a0 and 2 for PR HEAD 1da2421 in total

@jhadvig
Copy link
Member

jhadvig commented Apr 22, 2025

/retest

1 similar comment
@jhadvig
Copy link
Member

jhadvig commented Apr 22, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e7945a0 and 2 for PR HEAD 1da2421 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b0f115f and 1 for PR HEAD 1da2421 in total

@jhadvig jhadvig changed the title CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API OCPBUGS-53412,CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API Apr 23, 2025
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 23, 2025

@TheRealJon: This pull request references Jira Issue OCPBUGS-53412, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-4479 which is a valid jira issue.

This pull request references CONSOLE-4061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Update custom logo sync to come before console config and deployment syncs
  • custom logo sync returns on failure, no need for "ok to mount" conditions when building console config and deployments
  • Remove extra custom logo related args from deployment and console config sync functions. Use existing console operator config.
  • Add SyncCustomLogos function to validate and sync configmaps defined by new API
  • Update SyncCustomLogoConfigMap to remove bool return value
  • Share UpdateCustomLogoSyncSource between SyncCustomLogos and SyncCustomLogoConfigMap
  • Update DefaultConfigMap func to handle new API
  • Update config builder to convert old API to new, and sync either new API or converted old API to console config
  • Update DefaultDeployment to create appropriate volumes depending on CustomLogoFile or Logos
  • Update unit and e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member

jhadvig commented Apr 23, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 23, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 23, 2025

@jhadvig: This pull request references Jira Issue OCPBUGS-53412, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

This pull request references CONSOLE-4479 which is a valid jira issue.

This pull request references CONSOLE-4061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yanpzhan April 23, 2025 13:07
@jhadvig
Copy link
Member

jhadvig commented Apr 23, 2025

flaking test:

 ✖  shipwright-ci.feature 

@openshift openshift deleted a comment from openshift-ci bot Apr 23, 2025
@jhadvig
Copy link
Member

jhadvig commented Apr 23, 2025

/override ci/prow/e2e-aws-console

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console

In response to this:

/override ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b6949a5 into openshift:main Apr 23, 2025
12 checks passed
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Jira Issue OCPBUGS-53412: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-53412 has not been moved to the MODIFIED state.

In response to this:

  • Update custom logo sync to come before console config and deployment syncs
  • custom logo sync returns on failure, no need for "ok to mount" conditions when building console config and deployments
  • Remove extra custom logo related args from deployment and console config sync functions. Use existing console operator config.
  • Add SyncCustomLogos function to validate and sync configmaps defined by new API
  • Update SyncCustomLogoConfigMap to remove bool return value
  • Share UpdateCustomLogoSyncSource between SyncCustomLogos and SyncCustomLogoConfigMap
  • Update DefaultConfigMap func to handle new API
  • Update config builder to convert old API to new, and sync either new API or converted old API to console config
  • Update DefaultDeployment to create appropriate volumes depending on CustomLogoFile or Logos
  • Update unit and e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.19.0-202504232036.p0.gb6949a5.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-04-04-170728

@TheRealJon TheRealJon deleted the CONSOLE-4061 branch April 24, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.