-
Notifications
You must be signed in to change notification settings - Fork 136
OCPBUGS-53412,CONSOLE-4479,CONSOLE-4061: Update console operator to support new custom logos API #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TheRealJon
commented
Feb 24, 2025
•
edited
Loading
edited
- Update custom logo sync to come before console config and deployment syncs
- custom logo sync returns on failure, no need for "ok to mount" conditions when building console config and deployments
- Remove extra custom logo related args from deployment and console config sync functions. Use existing console operator config.
- Add SyncCustomLogos function to validate and sync configmaps defined by new API
- Update SyncCustomLogoConfigMap to remove bool return value
- Share UpdateCustomLogoSyncSource between SyncCustomLogos and SyncCustomLogoConfigMap
- Update DefaultConfigMap func to handle new API
- Update config builder to convert old API to new, and sync either new API or converted old API to console config
- Update DefaultDeployment to create appropriate volumes depending on CustomLogoFile or Logos
- Update unit and e2e tests
@TheRealJon: This pull request references CONSOLE-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9effe01
to
7e6932b
Compare
/hold Depends on openshift/api#2177 |
7e6932b
to
1468af8
Compare
2877f48
to
153f47b
Compare
153f47b
to
f4726dd
Compare
@TheRealJon: This pull request references CONSOLE-4479 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. This pull request references CONSOLE-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1dcbda4
to
6a61390
Compare
/retest |
|
/retest |
/label tide/merge-method-squash |
There is not blocking issue for current feature, we can discuss any confusion later, so approve the pr now. |
@TheRealJon: This pull request references CONSOLE-4479 which is a valid jira issue. This pull request references CONSOLE-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label px-approved |
/label docs-approved |
/retest |
1 similar comment
/retest |
@TheRealJon: This pull request references Jira Issue OCPBUGS-53412, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references CONSOLE-4479 which is a valid jira issue. This pull request references CONSOLE-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jhadvig: This pull request references Jira Issue OCPBUGS-53412, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: This pull request references CONSOLE-4479 which is a valid jira issue. This pull request references CONSOLE-4061 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
flaking test:
|
/override ci/prow/e2e-aws-console |
@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@TheRealJon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@TheRealJon: Jira Issue OCPBUGS-53412: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-53412 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console-operator |
Fix included in accepted release 4.19.0-0.nightly-2025-04-04-170728 |