CORS-3993: Promote GCPClusterHostedDNS to Default

[sadasu]

Promotes GCP Cluster Hosted DNS feature from techpreview to available by default.

[openshift-ci]

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

/jira refresh

[openshift-ci-robot]

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead.

In response to this:

Promotes GCP Cluster Hosted DNS feature from techpreview to available by default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gpei]

/test verify-feature-promotion

[sadasu]

/test e2e-aws-ovn-hypershift

[JoelSpeed]

/test verify-feature-promotion

[gpei]

/retest

[JoelSpeed]

@sadasu Do you have any E2E tests that will actually demonstrate this feature? IIRC, it's opt-in right? I would expect therefore to see some periodics configuring this feature and we can then check the install success rate for those? And perhaps any particular tests that cover the feature once installed?

[JoelSpeed]

Note, I believe the verify feature promotion is not showing the correct data right now

See https://redhat-internal.slack.com/archives/C01CQA76KMX/p1755082750657859

[sadasu]

/test verify-feature-promotion

[sadasu]

@sadasu Do you have any E2E tests that will actually demonstrate this feature? IIRC, it's opt-in right? I would expect therefore to see some periodics configuring this feature and we can then check the install success rate for those? And perhaps any particular tests that cover the feature once installed?

The periodic e2e job shows install success. You should see it in CR too.

Yes, this feature is an opt-int and needs to be specifically enabled via install-config.

[openshift-ci]

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview	d668c33	link	true	/test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gpei]

/test verify-feature-promotion

[gpei]

I see the overall install success rate for GCP platform in the past week is 95.1% now, so re-triggered the verify-feature-promotion test and it did pass.
Not sure if we want to use this test result to complete the merge of this PR.

[candita]

@sadasu @JoelSpeed we are seeing some issues with default DNS that are causing Sippy conformance test failures. Please do not merge. cc @Miciah @alebedev87

[sadasu]

/hold

@candita, @JoelSpeed is already aware.

[patrickdillon]

@sadasu @JoelSpeed we are seeing some issues with default DNS that are causing Sippy conformance test failures. Please do not merge. cc @Miciah @alebedev87

We have worked with Candace, Miciah and Andrey to identify and work on solution for the e2e failures. To make a long story short, Custom DNS on a cloud is similar to how UPI or baremetal platforms setup DNS. There were certain assumptions baked into the existing E2E tests that always expect cloud platforms to use cloud DNS (despite the API contract). The failing tests did not indicate a problem in the product, only in the tests. We're working on getting those squared away long term, and in the short-term are skipping the problem tests for this specific job (origin skips the tests permanently for baremetal networking platforms).

[sadasu]

@sadasu @JoelSpeed we are seeing some issues with default DNS that are causing Sippy conformance test failures. Please do not merge. cc @Miciah @alebedev87

We have worked with Candace, Miciah and Andrey to identify and work on solution for the e2e failures. To make a long story short, Custom DNS on a cloud is similar to how UPI or baremetal platforms setup DNS. There were certain assumptions baked into the existing E2E tests that always expect cloud platforms to use cloud DNS (despite the API contract). The failing tests did not indicate a problem in the product, only in the tests. We're working on getting those squared away long term, and in the short-term are skipping the problem tests for this specific job (origin skips the tests permanently for baremetal networking platforms).

/hold cancel

For the above reasons.

[sadasu]

/test verify-feature-promotion

[JoelSpeed]

/lgtm

/hold are we holding this until after branching?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

/hold are we holding this until after branching?

We are still hoping to merge this in 4.20 before branching.