Skip to content

Conversation

patrickdillon
Copy link
Contributor

Installer feature gates need to have "install" in the title for the test analyzer. This commit adds feature gates for AWSClusterHostedDNSInstall, GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their counterparts without the -install suffix, which will be removed in a follow up PR.

Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2025
@openshift-ci openshift-ci bot requested review from deads2k and yuqi-zhang July 24, 2025 18:10
@patrickdillon patrickdillon force-pushed the new-installer-replacements-fgs branch from 3bc64df to e1a95f4 Compare July 24, 2025 18:18
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2025
Installer feature gates need to have "install" in the title for the test analyzer.
This commit adds feature gates for AWSClusterHostedDNSInstall,
GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their
counterparts without the -install suffix, which will be removed in a follow up
PR.
@sadasu
Copy link
Contributor

sadasu commented Jul 24, 2025

#2300 depends on this and has to be rebased to use the new feature gate name after this PR merges.

@sadasu sadasu mentioned this pull request Jul 25, 2025
5 tasks
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 92b1455 and 2 for PR HEAD 4f089ea in total

Copy link
Contributor

openshift-ci bot commented Jul 29, 2025

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6d3c4e2 into openshift:master Jul 29, 2025
27 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507290444.p0.g6d3c4e2.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants