-
Notifications
You must be signed in to change notification settings - Fork 562
features: add installer replacement feature gates #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features: add installer replacement feature gates #2423
Conversation
Hello @patrickdillon! Some important instructions when contributing to openshift/api: |
3bc64df
to
e1a95f4
Compare
Installer feature gates need to have "install" in the title for the test analyzer. This commit adds feature gates for AWSClusterHostedDNSInstall, GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their counterparts without the -install suffix, which will be removed in a follow up PR.
e1a95f4
to
0339e56
Compare
#2300 depends on this and has to be rebased to use the new feature gate name after this PR merges. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@patrickdillon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
Installer feature gates need to have "install" in the title for the test analyzer. This commit adds feature gates for AWSClusterHostedDNSInstall, GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their counterparts without the -install suffix, which will be removed in a follow up PR.