Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: go 1.22.8->1.23.5 #1173

Closed
wants to merge 1 commit into from
Closed

go.mod: go 1.22.8->1.23.5 #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/openshift-kni/numaresources-operator

go 1.22.0
go 1.23.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the requirements of the module, which are debatable: do we use language/stdlib features only available on 1.23? Can't recall obvious offenders.

What we should bump is the minimum version we use in the builder images, makefiles and so forth

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref: https://go.dev/ref/mod#go-mod-file-go

Copy link
Member Author

@shajmakh shajmakh Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment and the reference. Following offline conversation, we should be fine with what we have u/s as it is already updated to use 1.23 builder and thus will be fetching the latest


toolchain go1.22.8
toolchain go1.23.5

require (
github.com/aquasecurity/go-version v0.0.0-20210121072130-637058cfe492
Expand Down
Loading