go.mod: go 1.22.8->1.23.5 #1173
Conversation
1.23.5 introduce security fixes, bump to that build. Signed-off-by: Shereen Haj <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -1,8 +1,8 @@ | |||
| module github.com/openshift-kni/numaresources-operator | |||
|
|
|||
| go 1.22.0 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
these are the requirements of the module, which are debatable: do we use language/stdlib features only available on 1.23? Can't recall obvious offenders.
What we should bump is the minimum version we use in the builder images, makefiles and so forth
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for your comment and the reference. Following offline conversation, we should be fine with what we have u/s as it is already updated to use 1.23 builder and thus will be fetching the latest
|
/close |
|
@shajmakh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1.23.5 introduce security fixes, bump to that build.