8359380: Rework deferral profile logic after JDK-8346465

[mrserb]

The ICC_Profile class has special logic to postpone actual data loading for as long as possible. To support this we use a lightweight object that stores commonly used metadata such as the number of components that can be accessed without triggering full profile loading. But we currently discard this object once the profile is used for color conversion since the application might modify the profile data in a way that becomes inconsistent with what was previously cached.

After JDK-8346465 all standard ICC profiles bundled with the JDK are now immutable. This means the deferral logic can be simplified: we no longer need to drop the lightweight metadata object since the underlying data is guaranteed to remain unchanged.

This patch includes two changes:

1. We stop discarding the deferred metadata object. It will now used consistently removing the need for a special flag to identify standard profiles.

2. While implementing the logic above I noticed a workaround introduced for JDK-8272860 no longer applies. This workaround relied on getNumComponents() triggering header profile loading which no longer happens for standard profiles. Initially(at the moment the JDK-8272860 was filed) this caused test failures but due to unrelated changes all those tests now pass. To ensure this issue is still caught in the future, I’ve added a new test case that specifically verifies this behavior.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359380: Rework deferral profile logic after JDK-8346465 (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26179/head:pull/26179
$ git checkout pull/26179

Update a local copy of the PR:
$ git checkout pull/26179
$ git pull https://git.openjdk.org/jdk.git pull/26179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26179

View PR using the GUI difftool:
$ git pr show -t 26179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26179.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359380: Rework deferral profile logic after JDK-8346465

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

The test compared data from the lightweight object with the actual data used after the profile is fully loaded. Since we now always use the lightweight object, I had to create a copy of the standard profile to make sure the actual profile data is used.

[mlbridge]

Webrevs

• 02: Full - Incremental (b095c5b2)
• 01: Full - Incremental (78ba5480)
• 00: Full (4278a0b8)

[mrserb]

@honkar-jdk please take a look

[prrace]

This looks OK, but I'm waiting for a full test run to complete.

[prrace]

Tests pass.

[mrserb]

/integrate

[openjdk]

Going to push as commit 4c80780.
Since your change was applied there have been 7 commits pushed to the master branch:

• 655dc51: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics
• f2f7a49: 8365071: ARM32: JFR intrinsic jvm_commit triggers C2 regalloc assert
• e04a310: 8364806: Test sun/security/krb5/config/IncludeRandom.java times out on Windows
• ... and 4 more: https://git.openjdk.org/jdk/compare/c9ecedd2260c7f0114227aafc7f7f85e7c4c07c5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 4c80780.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.