chore: add test to cover not sending empty array when other has data #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2024
sergiught
previously approved these changes
Feb 9, 2024
rhamzeh
requested changes
Feb 12, 2024
There was a problem hiding this comment.
As discussed offline, we're aiming not to have the app short circuit when both Writes and Deletes are not provided, instead we want to add test and ensure that if they are an empty array, they are not sent (as fields) to the API.
So:
| OpenFgaClient User Request | Sent to the API |
|---|---|
Write(writes=[tupleA], deletes=[tupleB]) |
Write(writes=[tupleA], deletes=[tupleB]) |
Write(writes=[], deletes=[tupleA]) |
Write(deletes=[tupleA]) |
Write(writes=[tupleA, deletes=[]) |
Write(writes=[tupleA]) |
Write(writes=[], deletes=[]) |
Write() |
ewanharris
force-pushed
the
feat/299-js-go-noop-empty
branch
from
c9a600c to
39b6c48
Compare
ewanharris
changed the title
4 tasks
ewanharris
force-pushed
the
feat/299-js-go-noop-empty
branch
from
39b6c48 to
acf8eac
Compare
|
@rhamzeh I've updated the PR to include a Currently this isn't really valuable in SDKs where we're not matching the body in mocks, I'll spend some time tomorrow seeing if I can improve SDKs other than python a little further to validate this better. |
rhamzeh
approved these changes
Feb 12, 2024
github-merge-queue bot
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Feb 12, 2024
…44) ## Description Adds the `Deletes` property to the test to ensure that we don't pass this when it is empty. Given that we don't match on body this isn't really much gain but it will help to ensure we maintain this in future if we improve testing. ## References Part of openfga/sdk-generator#299 Generated from openfga/sdk-generator#306 ## Review Checklist - [x] I have clicked on ["allow edits by maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). - [ ] I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above] - [x] The correct base branch is being used, if not `main` - [ ] I have added tests to validate that the change in functionality is working as expected
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the Go, JS, and Python SDKs make passing no deletes or writes to the
writecommand perform a no-op and just return an empty responseReferences
Part of #299
SDK PRs to come shortly
Review Checklist
main