chore: add test to cover not sending empty array when other has data

openfga · Feb 9, 2024 · c9a600c · c9a600c
1 parent 3a5f658
commit c9a600c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/config/clients/go/template/client/client_test.mustache b/config/clients/go/template/client/client_test.mustache
@@ -961,6 +961,7 @@ func Test{{appShortName}}Client(t *testing.T) {
 				Relation: "viewer",
 				Object:   "document:roadmap",
 			} },
+			Deletes: []ClientTupleKeyWithoutCondition{},
 		}
 		options := ClientWriteOptions{
 			AuthorizationModelId: {{packageName}}.PtrString("01GAHCE4YVKPQEKZQHT2R89MQV"),

diff --git a/config/clients/js/template/tests/client.test.ts.mustache b/config/clients/js/template/tests/client.test.ts.mustache
@@ -370,6 +370,27 @@ describe("{{appTitleCaseName}} Client", () => {
           writes: []
         });
       });
+
+      it("should properly call the {{appShortName}} Write API when providing one empty array", async () => {
+        const tuple = {
+          user: "user:81684243-9356-4421-8fbf-a4f8d36aa31b",
+          relation: "admin",
+          object: "workspace:1",
+        };
+        const scope = nocks.write(baseConfig.storeId!);
+
+        expect(scope.isDone()).toBe(false);
+        const data = await fgaClient.write({
+          writes: [tuple],
+          deletes: []
+        }, {
+          authorizationModelId: "01GXSA8YR785C4FYS3C0RTG7B1",
+        });
+
+        expect(scope.isDone()).toBe(true);
+        expect(data.writes.length).toBe(1);
+        expect(data.deletes.length).toBe(0);
+      });
     });
 
     describe("WriteTuples", () => {

diff --git a/config/clients/python/template/client/test_client.mustache b/config/clients/python/template/client/test_client.mustache
@@ -1337,6 +1337,7 @@ class TestOpenFgaClient(IsolatedAsyncioTestCase):
                             user="user:81684243-9356-4421-8fbf-a4f8d36aa31b",
                         )
                     ],
+                writes=[],
             )
             transaction = WriteTransactionOpts(disabled=True, max_per_chunk=1, max_parallel_requests=10)
             {{#asyncio}}await {{/asyncio}}api_client.write(

diff --git a/config/clients/python/template/client/test_client_sync.mustache b/config/clients/python/template/client/test_client_sync.mustache
@@ -1316,6 +1316,7 @@ class TestOpenFgaClient(IsolatedAsyncioTestCase):
                             user="user:81684243-9356-4421-8fbf-a4f8d36aa31b",
                         )
                     ],
+                writes=[],
             )
             transaction = WriteTransactionOpts(disabled=True, max_per_chunk=1, max_parallel_requests=10)
             api_client.write(