Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [FC-0078] Bugfixes part 1 #570

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

IvanStepanok
Copy link
Contributor

@IvanStepanok IvanStepanok commented Feb 14, 2025

Address issues:
#568
#571
#572

@openedx-webhooks
Copy link

Thanks for the pull request, @IvanStepanok!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Feb 14, 2025
@rnr
Copy link
Contributor

rnr commented Feb 20, 2025

@IvanStepanok, please note this bug - the full profile image is not saved when switching between full and limited profiles:

Screen.Recording.2025-02-20.at.16.50.29.mov

rnr
rnr previously approved these changes Feb 21, 2025
Copy link
Contributor

@rnr rnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just minor code style note and fix tests please

@@ -126,7 +138,7 @@ public class EditProfileViewModel: ObservableObject {
isShowProgress = true
do {
if try await interactor.deleteProfilePicture() {
inputImage = CoreAssets.noAvatar.image
// inputImage = CoreAssets.noAvatar.image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanStepanok do we need this commented out line?

@volodymyr-chekyrta volodymyr-chekyrta merged commit 54f1105 into openedx:develop Feb 25, 2025
8 checks passed
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0a267b5) to head (dd94f44).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #570   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
5 participants