[codex] [2/4] Generalize plugin suggestion presentation#28400
Merged
adaley-openai merged 1 commit intoJun 16, 2026
Conversation
This was referenced Jun 15, 2026
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
8f68622 to
d1ab190
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-endpoint-client
branch
from
3963375 to
7d0c048
Compare
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
2 times, most recently
from
58cdc7a to
155cdfe
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-endpoint-client
branch
from
7d0c048 to
acb8711
Compare
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
2 times, most recently
from
132f097 to
0c7a6a4
Compare
xl-openai
approved these changes
Jun 16, 2026
sayan-oai
approved these changes
Jun 16, 2026
adaley-openai
changed the title
sayan-oai
reviewed
Jun 16, 2026
Comment on lines
+49
to
+56
| pub(crate) enum ToolSuggestPresentation { | ||
| ListTool, | ||
| #[allow(dead_code)] | ||
| DeveloperContext, | ||
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub(crate) struct ToolSuggestCandidates { |
Collaborator
There was a problem hiding this comment.
nit/question-- is this ever going to be for something other than plugins? we renamed the tool from tool_suggest to request_plugin_install, and now we are removing connectors. should the types be more plugin specific?
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-endpoint-client
branch
from
65bc302 to
6f17e4e
Compare
adaley-openai
added a commit
that referenced
this pull request
Jun 16, 2026
Summary - Add authenticated parsing for `/ps/plugins/suggested?scope=GLOBAL`, including remote plugin and connector app identities. - Validate, deduplicate, sort, and cap endpoint candidates before caching them by backend and account identity. - Deduplicate concurrent cache misses and warm recommendations from the existing remote-installed-plugin refresh path used at startup and after account changes. - Keep endpoint results model-invisible in this PR; failures and responses without `enabled: true` resolve to legacy mode. Stack - 1/3. Follow-up: #28400 generalizes plugin suggestion presentation without activating endpoint recommendations. - Final activation: #27704. Validation - `just test -p codex-core-plugins recommended_plugins` - `just fix -p codex-core-plugins` - `just fmt` - `git diff --check`
Base automatically changed from
dev/adaley/recommended-plugin-endpoint-client
to
main
June 16, 2026 22:22
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
0c7a6a4 to
8c9169f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Validation
just test -p codex-core request_plugin_installjust test -p codex-core spec_planjust fix -p codex-corejust fmtgit diff --check