Skip to content

[codex] [3/3] Activate endpoint plugin recommendations#27704

Open
adaley-openai wants to merge 2 commits into
dev/adaley/generalize-plugin-suggestion-toolsfrom
dev/adaley/recommended-plugin-hint-experiment
Open

[codex] [3/3] Activate endpoint plugin recommendations#27704
adaley-openai wants to merge 2 commits into
dev/adaley/generalize-plugin-suggestion-toolsfrom
dev/adaley/recommended-plugin-hint-experiment

Conversation

@adaley-openai

@adaley-openai adaley-openai commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Await endpoint recommendation selection while constructing each authenticated turn, removing the first-turn cache race.
  • Snapshot and filter endpoint candidates once per turn, then use that same set for the bounded contextual user fragment, tool exposure, and exact install validation.
  • Persist whether the recommendation fragment survives in model context; resumed threads without it stay on the legacy list-backed workflow, and full-context replacement recomputes the marker.
  • Hide the legacy list tool in endpoint mode and preserve legacy discovery unchanged when the endpoint is disabled or unavailable.
  • Keep remote plugin and connector app identities out of model-visible context and attach them only to Codex-owned elicitation metadata.

Stack

Validation

  • just test -p codex-protocol
  • just test -p codex-state -p codex-rollout
  • just test -p codex-core request_plugin_install
  • just test -p codex-core full_context_reinjection_clears_stale_recommended_plugins_marker
  • just test -p codex-app-server first_turn_after_external_login_waits_for_recommended_plugins
  • just fix -p codex-core -p codex-protocol -p codex-app-server
  • just fmt
  • git diff --check
  • Full just test -p codex-core: 2,649 passed and 88 environment-dependent tests failed because this sandbox cannot write ~/.codex/sqlite, nest Seatbelt, or locate auxiliary test binaries.

@adaley-openai adaley-openai requested a review from a team as a code owner June 11, 2026 23:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e59decf6bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/context/recommended_plugins_instructions.rs
Comment thread codex-rs/core/src/context/recommended_plugins_instructions.rs Outdated
Comment thread codex-rs/core/src/session/turn.rs
@adaley-openai adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch 5 times, most recently from b54d464 to 3fc7249 Compare June 15, 2026 16:32
Comment thread codex-rs/core-plugins/src/manager.rs
Comment thread codex-rs/app-server/src/request_processors/account_processor.rs Outdated
@adaley-openai adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from f624e26 to 831815e Compare June 15, 2026 22:25
@adaley-openai adaley-openai changed the title [codex] Add endpoint-driven plugin recommendations [codex] [3/3] Activate endpoint plugin recommendations Jun 15, 2026
@adaley-openai adaley-openai changed the base branch from main to dev/adaley/generalize-plugin-suggestion-tools June 15, 2026 22:25
@adaley-openai adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 8f68622 to d1ab190 Compare June 15, 2026 23:25
@adaley-openai adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 831815e to 1aaa60a Compare June 15, 2026 23:25
@adaley-openai adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch 2 times, most recently from 58cdc7a to 155cdfe Compare June 15, 2026 23:35
@adaley-openai adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 1aaa60a to 58db110 Compare June 15, 2026 23:36
@adaley-openai adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 155cdfe to 132f097 Compare June 16, 2026 00:10
@adaley-openai adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 58db110 to 3b66932 Compare June 16, 2026 00:11
@adaley-openai adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 132f097 to 0c7a6a4 Compare June 16, 2026 00:28
Comment thread codex-rs/core/src/session/mod.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants