Fix: Not displaying all transactions on button click #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Feb 13, 2024
| for (transaction in allTransactions!!) { | ||
| if (transaction.transactionType == type) { | ||
| filterTransactions.add(transaction) | ||
| if(type!=null){ |
There was a problem hiding this comment.
I think someone while migrating java to kotlin have made this nullable but this would not be nullabe, please remove and format and update the PR.
There was a problem hiding this comment.
@therajanmaurya I have updated the PR. Can u please check.
therajanmaurya
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1516
Screenshots
fix.mp4
Description
Added an extra check if the filter type is "All" then display all credit and debit transactions
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.