Squashed commit of the following:

commit 880471cf58cc7927998cdaf1b52842ef7cc193b4
Author: devrahul-2508 <[email protected]>
Date:   Mon Feb 19 22:17:47 2024 +0530

   Fix: Not displaying all transactions on button click

Author: devrahul-2508

mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/HistoryContract.kt

@@ -26,7 +26,7 @@ interface HistoryContract {
 
     interface TransactionsHistoryPresenter : BasePresenter {
         fun fetchTransactions()
-        fun filterTransactionType(type: TransactionType?)
+        fun filterTransactionType(type: TransactionType)
         fun handleTransactionClick(transactionIndex: Int)
     }
 

mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/presenter/HistoryPresenter.kt

@@ -20,8 +20,7 @@ import java.util.Locale
 import javax.inject.Inject
 
 class HistoryPresenter @Inject constructor(
-    private val mUseCaseHandler: UseCaseHandler,
-    private val mLocalRepository: LocalRepository
+    private val mUseCaseHandler: UseCaseHandler, private val mLocalRepository: LocalRepository
 ) : TransactionsHistoryPresenter, TransactionsHistoryAsync {
     @JvmField
     @Inject
@@ -59,8 +58,7 @@ class HistoryPresenter @Inject constructor(
                 override fun onSuccess(response: FetchAccount.ResponseValue?) {
                     mAccount = response?.account
                     response?.account?.id?.let {
-                        mTransactionsHistory
-                            ?.fetchTransactionsHistory(it)
+                        mTransactionsHistory?.fetchTransactionsHistory(it)
                     }
                 }
 
@@ -70,30 +68,29 @@ class HistoryPresenter @Inject constructor(
             })
     }
 
-    override fun filterTransactionType(type: TransactionType?) {
+    override fun filterTransactionType(type: TransactionType) {
         val filterTransactions: MutableList<Transaction> = ArrayList()
-        if(type!=null){
+
+        if (type == TransactionType.OTHER) {
+            if (allTransactions!!.isNotEmpty()) {
+                mHistoryView!!.refreshTransactions(allTransactions)
+            } else {
+                showEmptyStateView()
+            }
+        } else {
             for (transaction in allTransactions!!) {
                 if (transaction.transactionType == type) {
                     filterTransactions.add(transaction)
                 }
             }
-            if (filterTransactions.isEmpty()) {
-                showEmptyTransactionTypeStateView(type.toString().lowercase(Locale.getDefault()))
-            } else {
+            if (filterTransactions.isNotEmpty()) {
                 mHistoryView!!.refreshTransactions(filterTransactions)
-            }
-        }
-        else{
-            if(allTransactions!!.isEmpty()){
-                showEmptyStateView()
-            }
-            else{
-                mHistoryView!!.refreshTransactions(allTransactions)
+
+            } else {
+                showEmptyTransactionTypeStateView(type.toString().lowercase(Locale.getDefault()))
 
             }
         }
-
     }
 
     override fun handleTransactionClick(transactionIndex: Int) {
@@ -103,7 +100,8 @@ class HistoryPresenter @Inject constructor(
 
     private fun showErrorStateView() {
         mHistoryView!!.showStateView(
-            R.drawable.ic_error_state, R.string.error_oops,
+            R.drawable.ic_error_state,
+            R.string.error_oops,
             R.string.error_no_transaction_history_subtitle
         )
     }

mifospay/src/main/java/org/mifos/mobilewallet/mifospay/history/ui/HistoryFragment.kt

@@ -216,7 +216,7 @@ class HistoryFragment : BaseFragment(), HistoryView {
         btnFilterAll!!.setChipBackgroundColorResource(R.color.clickedblue)
         btnFilterCredits!!.setChipBackgroundColorResource(R.color.changedBackgroundColour)
         btnFilterDebits!!.setChipBackgroundColorResource(R.color.changedBackgroundColour)
-        mTransactionsHistoryPresenter!!.filterTransactionType(null)
+        mTransactionsHistoryPresenter!!.filterTransactionType(TransactionType.OTHER)
     }
 
     @OnClick(R.id.btn_filter_credits)