chore: Upgrade prometheus to 0.14 and clean up protobuf-related code in lib.rs
#2920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24254 24254
=====================================
Hits 19736 19736
Misses 4518 4518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
houseme
changed the title
prometheus to 0.14 and clean up protobuf-related code in lib.rsprometheus to 0.14 and clean up protobuf-related code in lib.rs
…nings - Eliminated unnecessary `.into()` type conversions in `lib.rs` to address Clippy's `useless conversion` warnings. - Improved code clarity and ensured compliance with Rust best practices. - Verified changes with `cargo clippy` to confirm no new warnings or errors.
|
After discussing with other maintainers, I am changing what I stated in #2769 (comment) to do one more release with the vulnerability addressed. In other words, this PR should be accepted. |
cijothomas
approved these changes
Apr 10, 2025
Yes，Changelog has been added，Thanks！ @cijothomas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2769