Update OTLP examples to use opentelemetry-appender-tracing, with filtering of the events from specific crates. #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
=======================================
- Coverage 73.6% 73.5% -0.1%
=======================================
Files 124 124
Lines 19482 19482
=======================================
- Hits 14341 14338 -3
- Misses 5141 5144 +3 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
May 22, 2024
| @@ -91,9 +93,21 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> { | |||
| let logger_provider = init_logs().unwrap(); | |||
|
|
|||
| // Create a new OpenTelemetryLogBridge using the above LoggerProvider. | |||
There was a problem hiding this comment.
Suggested change
| // Create a new OpenTelemetryLogBridge using the above LoggerProvider. | |
| // Create a new OpenTelemetryTracingBridge using the above LoggerProvider. |
cijothomas
approved these changes
May 22, 2024
cijothomas
reviewed
May 22, 2024
| log::set_max_level(Level::Info.to_level_filter()); | ||
| let layer = OpenTelemetryTracingBridge::new(&logger_provider); | ||
|
|
||
| // add a tracing filter to filter the events generated from the crates used by opentelemetry-otlp |
There was a problem hiding this comment.
please add a link to the tracking issue, and also warn that, the events from this layer will be filtered for this layer irrespective of if they occur inside OTLP Exporting or not, potentially leading to blind spots.
4 tasks
cijothomas
pushed a commit
that referenced
this pull request
May 22, 2024
lalitb
added a commit
to lalitb/opentelemetry-rust
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1797
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes