Skip to content

Commit a588455

Browse files
committed
Nit fix for review comments from open-telemetry#1798 (open-telemetry#1803)
1 parent 460d45b commit a588455

File tree

2 files changed

+18
-10
lines changed
  • opentelemetry-otlp/examples

2 files changed

+18
-10
lines changed

opentelemetry-otlp/examples/basic-otlp-http/src/main.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,17 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
8989
// emitting.
9090
let logger_provider = init_logs().unwrap();
9191

92-
// Create a new OpenTelemetryLogBridge using the above LoggerProvider.
92+
// Create a new OpenTelemetryTracingBridge using the above LoggerProvider.
9393
let layer = OpenTelemetryTracingBridge::new(&logger_provider);
9494

95-
// add a tracing filter to filter the events generated from the crates used by opentelemetry-otlp
96-
// Below filter level means:
97-
// - Logs at `info` level and above are allowed by default.
98-
// - Only `error` level logs from `hyper`, `tonic`, and `reqwest` crates are allowed.
95+
// Add a tracing filter to filter events from crates used by opentelemetry-otlp.
96+
// The filter levels are set as follows:
97+
// - Allow `info` level and above by default.
98+
// - Restrict `hyper`, `tonic`, and `reqwest` to `error` level logs only.
99+
// This ensures events generated from these crates within the OTLP Exporter are not looped back,
100+
// thus preventing infinite event generation.
101+
// Note: This will also drop events from these crates used outside the OTLP Exporter.
102+
// For more details, see: https://github.com/open-telemetry/opentelemetry-rust/issues/761
99103
let filter = EnvFilter::new("info")
100104
.add_directive("hyper=error".parse().unwrap())
101105
.add_directive("tonic=error".parse().unwrap())

opentelemetry-otlp/examples/basic-otlp/src/main.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,17 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
9292
// Initialize logs and save the logger_provider.
9393
let logger_provider = init_logs().unwrap();
9494

95-
// Create a new OpenTelemetryLogBridge using the above LoggerProvider.
95+
// Create a new OpenTelemetryTracingBridge using the above LoggerProvider.
9696
let layer = OpenTelemetryTracingBridge::new(&logger_provider);
9797

98-
// add a tracing filter to filter the events generated from the crates used by opentelemetry-otlp
99-
// Below filter level means:
100-
// - Logs at `info` level and above are allowed by default.
101-
// - Only `error` level logs from `hyper`, `tonic`, and `reqwest` crates are allowed.
98+
// Add a tracing filter to filter events from crates used by opentelemetry-otlp.
99+
// The filter levels are set as follows:
100+
// - Allow `info` level and above by default.
101+
// - Restrict `hyper`, `tonic`, and `reqwest` to `error` level logs only.
102+
// This ensures events generated from these crates within the OTLP Exporter are not looped back,
103+
// thus preventing infinite event generation.
104+
// Note: This will also drop events from these crates used outside the OTLP Exporter.
105+
// For more details, see: https://github.com/open-telemetry/opentelemetry-rust/issues/761
102106
let filter = EnvFilter::new("info")
103107
.add_directive("hyper=error".parse().unwrap())
104108
.add_directive("tonic=error".parse().unwrap())

0 commit comments

Comments
 (0)