Skip to content

test(flagd): Add support for e2e tests to use version.txt #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2025
Merged

test(flagd): Add support for e2e tests to use version.txt #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71ddccf
Exclude netframework from e2e tests
kylejuliandev Oct 1, 2025
63c539e
Add version.txt to Flagd E2E tests
kylejuliandev Oct 1, 2025
32a6667
Revert "Exclude netframework from e2e tests"
kylejuliandev Oct 1, 2025
a57b5ee
Address Gemini code comments
kylejuliandev Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed
Open in desktop
Submodule flagd-testbed updated 23 files
+0 −14 .github/workflows/ci.yml
+5 −19 .github/workflows/release-please.yml
+1 −1 .release-please-manifest.json
+86 −0 CHANGELOG.md
+0 −6 Makefile
+0 −7 README.md
+3 −3 flagd/Dockerfile
+3 −3 flagd/Dockerfile.unstable
+249 −0 gherkin/config.feature
+24 −0 gherkin/events.feature
+44 −0 gherkin/flagd-rpc-caching.feature
+1 −1 release-please-config.json
+5 −2 scripts/restart-wrapper.sh
+0 −22 sync/Dockerfile
+0 −17 sync/Dockerfile.unstable
+0 −91 sync/README.md
+0 −19 sync/go.mod
+0 −2,282 sync/go.sum
+0 −13 sync/main.go
+0 −50 sync/pkg/config.go
+0 −150 sync/pkg/file_watcher.go
+0 −136 sync/pkg/server.go
+1 −0 version.txt
4 changes: 2 additions & 2 deletions test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/FlagdSyncTestBedContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ public class FlagdSyncTestBedContainer
{
public IContainer Container { get; }

public FlagdSyncTestBedContainer()
public FlagdSyncTestBedContainer(string version)
{
Container = new ContainerBuilder()
.WithImage("ghcr.io/open-feature/flagd-testbed:v0.5.21")
.WithImage($"ghcr.io/open-feature/flagd-testbed:v{version}")
.WithPortBinding(8015, true)
.Build();
}
Expand Down
6 changes: 4 additions & 2 deletions ...roviders.Flagd.E2e.ProcessTest/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
<None Include="../../spec/specification/assets/gherkin/evaluation.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<!-- TODO: add reconnect tests (remove exclusion) -->
<!-- TODO: add remaining tests -->
<ItemGroup>
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/*.feature" Exclude="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd-reconnect.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/version.txt" Link="flagd-testbed-version.txt" DestinationFolder="." CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd-json-evaluator.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<ItemGroup>
Expand Down
9 changes: 8 additions & 1 deletion test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/TestHooks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.IO;
using System.Threading.Tasks;
using Microsoft.Extensions.Configuration;
using Reqnroll;
Expand All @@ -22,7 +23,13 @@ public static async Task StartContainerAsync()
return;
}

FlagdSyncTestBed = new FlagdSyncTestBedContainer();
#if NET8_0_OR_GREATER
var version = await File.ReadAllTextAsync("flagd-testbed-version.txt").ConfigureAwait(false);
#else
var version = File.ReadAllText("flagd-testbed-version.txt");
#endif

FlagdSyncTestBed = new FlagdSyncTestBedContainer(version.Trim());
await FlagdSyncTestBed.Container.StartAsync().ConfigureAwait(false);
}

Expand Down
4 changes: 2 additions & 2 deletions test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/FlagdRpcTestBedContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ public class FlagdRpcTestBedContainer
{
public IContainer Container { get; }

public FlagdRpcTestBedContainer()
public FlagdRpcTestBedContainer(string version)
{
Container = new ContainerBuilder()
.WithImage("ghcr.io/open-feature/flagd-testbed:v0.5.21")
.WithImage($"ghcr.io/open-feature/flagd-testbed:v{version}")
.WithPortBinding(8013, true)
.Build();
}
Expand Down
6 changes: 4 additions & 2 deletions ...ontrib.Providers.Flagd.E2e.RpcTest/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
<None Include="../../spec/specification/assets/gherkin/evaluation.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<!-- TODO: add reconnect tests (remove exclusion) -->
<!-- TODO: add remaining tests -->
<ItemGroup>
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/*.feature" Exclude="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd-reconnect.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/version.txt" Link="flagd-testbed-version.txt" DestinationFolder="." CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
<None Include="../../src/OpenFeature.Contrib.Providers.Flagd/flagd-testbed/gherkin/flagd-json-evaluator.feature" Link="../../../Features/%(Filename)%(Extension)" DestinationFolder="../../../Features/" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

<ItemGroup>
Expand Down
9 changes: 8 additions & 1 deletion test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/TestHooks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.IO;
using System.Threading.Tasks;
using Microsoft.Extensions.Configuration;
using Reqnroll;
Expand All @@ -22,7 +23,13 @@ public static async Task StartContainerAsync()
return;
}

FlagdTestBed = new FlagdRpcTestBedContainer();
#if NET8_0_OR_GREATER
var version = await File.ReadAllTextAsync("flagd-testbed-version.txt").ConfigureAwait(false);
#else
var version = File.ReadAllText("flagd-testbed-version.txt");
#endif

FlagdTestBed = new FlagdRpcTestBedContainer(version.Trim());
await FlagdTestBed.Container.StartAsync().ConfigureAwait(false);
}

Expand Down