test(flagd): Add support for e2e tests to use version.txt

[kylejuliandev]

This PR

Updates the flagd-testbed submodule to v0.5.18, the first version which introduced the version.txt file. Prior to this we were targeting v0.5.6. I had to tweak the included feature files as new additions were added. I think a separate PR is needed to add the missing e2e tests.

Related Issues

Fixes #306

Notes

Follow-up Tasks

• Add missing e2e test cases from the following feature files:
  • config.feature
  • events.feature
  • flagd-reconnect.feature
  • flagd-rpc-caching.feature

These tests may not be achievable yet if the dotnet flagd provider has not got support for the functionality.

The rpc and process project split does not give us much, so I think the next immediate change should be to merge both projects into one.

The later flagd-testbed gherkin files leverage attribute hooks, like @rpc and @process to mark tests for each type of flagd connection. The existing tests should be updated to utilise these hooks.

How to test

[gemini-code-assist]

Summary of Changes

Hello @kylejuliandev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the end-to-end testing infrastructure by upgrading the flagd-testbed submodule and introducing a more robust versioning mechanism. By updating the submodule and dynamically reading the flagd-testbed version, the tests can consistently target the correct flagd-testbed image, ensuring compatibility and leveraging the latest features. This change also involved minor adjustments to the included Gherkin feature files to reflect the updated submodule content.

Highlights

• flagd-testbed Submodule Update: The flagd-testbed submodule has been updated from v0.5.6 to v0.5.18, bringing in new features and changes, including the version.txt file.
• Dynamic Versioning for E2E Tests: End-to-end tests now dynamically read the flagd-testbed version from version.txt, allowing the test containers to be built with the correct, updated image version.
• Feature File Adjustments: The Gherkin feature files included in the test projects have been adjusted to align with the updated flagd-testbed submodule, explicitly including flagd.feature and flagd-json-evaluator.feature.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the flagd-testbed submodule and adapts the e2e tests to read the version from the new version.txt file. The changes are logical and well-contained. I've made a few suggestions to improve the code:

• Use asynchronous file I/O in the async test hooks for better performance and consistency.
• Remove the Byte Order Mark (BOM) that was accidentally introduced in one of the project files to prevent potential tooling issues.

The author has already noted the code duplication between the ProcessTest and RpcTest projects as a follow-up task, which is a good observation. Overall, this is a good step towards keeping the test infrastructure up to date.