-
Notifications
You must be signed in to change notification settings - Fork 81
[IMP] excise_management : Deposit & excise totals by line #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
4be4c3b to
fc89276
Compare
vava-odoo
reviewed
Oct 17, 2025
5b619ce to
1c12848
Compare
Contributor
Author
|
Hello @vava-odoo |
vava-odoo
reviewed
Oct 28, 2025
51ea9a3 to
88bc6d2
Compare
Contributor
Author
|
Hello @vava-odoo |
vava-odoo
approved these changes
Oct 28, 2025
Collaborator
vava-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
We still need to split the deposit part from excise_management, but that will be done in a future task.
57c5002 to
b545d11
Compare
b545d11 to
91cea21
Compare
Collaborator
|
@robodoo r+ squash |
Collaborator
|
Merge method set to squash. |
robodoo
pushed a commit
that referenced
this pull request
Oct 28, 2025
This commit adds fields to display deposit & excise totals by line on Sale Orders and Invoices. It also improves the deposit definition of a tax (group). Task-5127418 closes #1214 Signed-off-by: Vallaeys Valentin (vava) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 28, 2025
This commit adds fields to display deposit & excise totals by line on Sale Orders and Invoices. It also improves the deposit definition of a tax (group). Task-5127418 closes #1274 Forward-port-of: #1214 Signed-off-by: Vallaeys Valentin (vava) <[email protected]> Signed-off-by: Dhrumil Shah (dhrs) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Oct 28, 2025
This commit adds fields to display deposit & excise totals by line on Sale Orders and Invoices. It also improves the deposit definition of a tax (group). Task-5127418 closes #1274 Forward-port-of: #1214 Signed-off-by: Vallaeys Valentin (vava) <[email protected]> Signed-off-by: Dhrumil Shah (dhrs) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This commit adds fields to display deposit & excise totals by line on Sale Orders and Invoices. It also improves the deposit definition of a tax (group).
Task-5127418