[IMP] excise_management: code review update

Author: dhrs-odoo

excise_management/__manifest__.py

@@ -1,6 +1,6 @@
 {
     'name': 'Excise Management',
-    'version': '2.1',
+    'version': '2.2',
     'category': 'Inventory/Inventory',
     'author': 'Odoo S.A.',
     'depends': [

excise_management/data/base_automation.xml

@@ -23,7 +23,7 @@
     <record id="base_automation_8" model="base.automation">
         <field name="name">Sequence the taxes</field>
         <field name="model_id" ref="account.model_account_tax"/>
-        <field name="action_server_ids" eval="[(6, 0, [ref('requence_the_order_of_taxes')])]"/>
+        <field name="action_server_ids" eval="[(6, 0, [ref('resequence_the_order_of_taxes')])]"/>
         <field name="trigger">on_create_or_write</field>
         <field name="trigger_field_ids" eval="[(6, 0, [ref('account.field_account_tax__tax_group_id')])]"/>
     </record>

excise_management/data/ir_actions_server.xml

@@ -40,12 +40,12 @@ for fp in records:
         <field name="state">code</field>
         <field name="name">Add/Remove excise tax on Fiscal Position</field>
     </record>
-    <record id="requence_the_order_of_taxes" model="ir.actions.server">
-    <field name="code"><![CDATA[all_taxes = env['account.tax'].sudo().search([], order="x_is_deposit asc, x_is_excise desc, sequence asc")
+    <record id="resequence_the_order_of_taxes" model="ir.actions.server">
+        <field name="code"><![CDATA[all_taxes = env['account.tax'].sudo().search([], order="x_is_deposit asc, x_is_excise desc, sequence asc")
 for idx, tax in enumerate(all_taxes, start=1):
     tax['sequence'] = idx]]></field>
-    <field name="model_id" ref="account.model_account_tax"/>
-    <field name="state">code</field>
-    <field name="name">Sequence the taxes</field>
-  </record>
+        <field name="model_id" ref="account.model_account_tax"/>
+        <field name="state">code</field>
+        <field name="name">Sequence the taxes</field>
+    </record>
 </odoo>

excise_management/data/ir_model_fields.xml

@@ -268,7 +268,7 @@ for template in self:
         <field name="field_description">Excise Free Unit Price</field>
         <field name="model_id" ref="sale.model_sale_order_line"/>
         <field name="ttype">monetary</field>
-        <field name="depends">price_unit, tax_ids</field>
+        <field name="depends">price_unit, product_id</field>
         <field name="compute"><![CDATA[for record in self:
         record['x_excise_free_unit_price'] = record.price_unit - record.product_id.x_excise_amount]]></field>
         <field name="readonly" eval="True"/>
@@ -280,7 +280,7 @@ for template in self:
         <field name="field_description">Excises</field>
         <field name="model_id" ref="sale.model_sale_order_line"/>
         <field name="ttype">monetary</field>
-        <field name="depends">product_id, product_uom_qty</field>
+        <field name="depends">product_id, product_uom_qty, order_id.fiscal_position_id</field>
         <field name="compute"><![CDATA[for record in self:
         record['x_total_excises'] = record.product_id.x_excise_amount * record.product_uom_qty if not record.order_id.fiscal_position_id.x_is_fiscal_deposit else False]]></field>
         <field name="readonly" eval="True"/>
@@ -291,7 +291,7 @@ for template in self:
         <field name="field_description">Deposits</field>
         <field name="ttype">monetary</field>
         <field name="model_id" ref="sale.model_sale_order_line"/>
-        <field name="depends">price_unit, product_uom_qty, tax_ids.x_is_deposit</field>
+        <field name="depends">product_uom_qty, tax_ids</field>
         <field name="compute"><![CDATA[for record in self:
         deposit = sum(tax.amount for tax in record.tax_ids if tax.x_is_deposit)
         record['x_total_deposits'] = deposit * record.product_uom_qty]]></field>

excise_management/data/ir_ui_view.xml

@@ -139,7 +139,7 @@
         </field>
     </record>
     <record id="sale_order_form_view_customizations" model="ir.ui.view">
-        <field name="name">sale.order.form customization</field>
+        <field name="name">sale.order.form.inherit.excise_management</field>
         <field name="inherit_id" ref="sale.view_order_form"/>
         <field name="mode">extension</field>
         <field name="model">sale.order</field>