[IMP] *: adapt tests for mysterious egg

addons/account/models/account_move.py

@@ -5495,6 +5495,7 @@ def action_invoice_sent(self):
         self.ensure_one()
 
         report_action = self.action_send_and_print()
+        report_action['context'].update({'allow_partners_without_mail': True})
         if self.env.is_admin() and not self.env.company.external_report_layout_id and not self.env.context.get('discard_logo_check'):
             report_action = self.env['ir.actions.report']._action_configure_external_report_layout(report_action, "account.action_base_document_layout_configurator")
             report_action['context']['default_from_invoice'] = self.move_type == 'out_invoice'
@@ -5925,9 +5926,9 @@ def _get_invoice_next_payment_values(self, custom_amount=None):
             next_amount_to_pay = self.amount_residual
             next_payment_reference = self.name
             next_due_date = epd_installment['date_maturity']
-            discount_date = epd_installment['line'].discount_date
+            discount_date = epd_installment['line'].discount_date or fields.Date.context_today(self)
             discount_amount_currency = epd_installment['discount_amount_currency']
-            days_left = (discount_date - fields.Date.context_today(self)).days  # should never be lower than 0 since epd is valid
+            days_left = max(0, (discount_date - fields.Date.context_today(self)).days)  # should never be lower than 0 since epd is valid
             if days_left > 0:
                 discount_msg = _(
                     "Discount of %(amount)s if paid within %(days)s days",

addons/account/models/account_move_line.py

@@ -410,7 +410,8 @@ class AccountMoveLine(models.Model):
     discount_date = fields.Date(
         string='Discount Date',
         store=True,
-        help='Last date at which the discounted amount must be paid in order for the Early Payment Discount to be granted'
+        help='Last date at which the discounted amount must be paid in order for the Early Payment Discount to be granted',
+        readonly=True
     )
     # Discounted amount to pay when the early payment discount is applied
     discount_amount_currency = fields.Monetary(

addons/account/models/account_move_send.py

@@ -183,7 +183,7 @@ def _get_default_mail_partner_ids(self, move, mail_template, mail_lang):
             partner_to = self._get_mail_default_field_value_from_template(mail_template, mail_lang, move, 'partner_to')
             partner_ids = mail_template._parse_partner_to(partner_to)
             partners |= self.env['res.partner'].sudo().browse(partner_ids).exists()
-        return partners.filtered('email')
+        return partners if self.env.context.get('allow_partners_without_mail') else partners.filtered('email')
 
     # -------------------------------------------------------------------------
     # ATTACHMENTS

addons/account/models/account_reconcile_model.py

@@ -28,7 +28,6 @@ class AccountReconcileModelLine(models.Model):
             ('percentage', 'Percentage of balance'),
             ('percentage_st_line', 'Percentage of statement line'),
             ('regex', 'From label'),
-            ('from_transaction_details', 'From Transaction Details'),
         ],
         required=True,
         default='percentage',
@@ -71,7 +70,7 @@ def _validate_amount(self):
                 raise UserError(_("Balance percentage can't be 0"))
             if record.amount_type == 'percentage' and record.amount == 0:
                 raise UserError(_("Statement line percentage can't be 0"))
-            if record.amount_type in {'regex', 'from_transaction_details'}:
+            if record.amount_type == 'regex':
                 try:
                     re.compile(record.amount_string)
                 except re.error:

addons/account/models/account_tax.py

@@ -253,7 +253,7 @@ def _constrains_cash_basis_transition_account(self):
     @api.model
     @api.readonly
     def name_search(self, name='', domain=None, operator='ilike', limit=100):
-        domain = Domain(domain)
+        domain = Domain(domain or Domain.TRUE)
         if 'search_default_domestictax' in self.env.context:
             domain &= Domain('fiscal_position_ids', '=', False) | Domain('fiscal_position_ids.is_domestic', '=', True)
         if fp_id := self.env.context.get('dynamic_fiscal_position_id'):
@@ -1291,9 +1291,9 @@ def _import_base_line_extra_tax_data(self, base_line, extra_tax_data):
             extra_tax_data
             and extra_tax_data.get('manual_tax_amounts')
             and base_line['currency_id'].id == extra_tax_data['currency_id']
-            and base_line['currency_id'].is_zero(base_line['price_unit'] - extra_tax_data['price_unit'])
-            and base_line['currency_id'].is_zero(base_line['discount'] - extra_tax_data['discount'])
-            and base_line['currency_id'].is_zero(base_line['quantity'] - extra_tax_data['quantity'])
+            and base_line['currency_id'].compare_amounts(base_line['price_unit'], extra_tax_data['price_unit']) == 0
+            and base_line['currency_id'].compare_amounts(base_line['discount'], extra_tax_data['discount']) == 0
+            and base_line['currency_id'].compare_amounts(base_line['quantity'], extra_tax_data['quantity']) == 0
             and all(str(tax.id) in extra_tax_data['manual_tax_amounts'] for tax in base_line['tax_ids'])
         ):
             results['manual_tax_amounts'] = extra_tax_data['manual_tax_amounts']
@@ -2757,7 +2757,10 @@ def _reduce_base_lines_with_grouping_function(self, base_lines, grouping_functio
                 quantity=1.0,
                 discount=0.0,
             )
-            grouping_key = {'tax_ids': new_base_line['tax_ids']}
+            grouping_key = {
+                'tax_ids': new_base_line['tax_ids'],
+                'computation_key': base_line['computation_key'],
+            }
             if grouping_function:
                 grouping_key.update(grouping_function(new_base_line))
             grouping_key = frozendict(grouping_key)
@@ -2770,12 +2773,21 @@ def _reduce_base_lines_with_grouping_function(self, base_lines, grouping_functio
             if target_base_line:
                 target_base_line['price_unit'] += new_base_line['price_unit']
             else:
-                new_base_line = base_line_map[grouping_key] = self._prepare_base_line_for_taxes_computation(
+                target_base_line = base_line_map[grouping_key] = self._prepare_base_line_for_taxes_computation(
                     new_base_line,
                     **grouping_key,
                 )
+                target_base_line['manual_tax_amounts'] = {}
             aggregated_base_lines.setdefault(grouping_key, []).append(base_line)
 
+            manual_tax_amounts = target_base_line['manual_tax_amounts']
+            for tax_id, amounts in (base_line['manual_tax_amounts'] or {}).items():
+                aggregated_amounts = manual_tax_amounts.setdefault(tax_id, {'tax_amount_currency': 0.0})
+                aggregated_amounts['tax_amount_currency'] += amounts['tax_amount_currency']
+                if 'base_amount_currency' in amounts:
+                    aggregated_amounts.setdefault('base_amount_currency', 0.0)
+                    aggregated_amounts['base_amount_currency'] += amounts['base_amount_currency']
+
         # Remove zero lines.
         base_line_map = {
             grouping_key: base_line
@@ -2815,8 +2827,6 @@ def _apply_base_lines_manual_amounts_to_reach(self, base_lines, target_amount_cu
         :param target_amount_currency: The expected total amount for the base lines passed as parameter.
         """
         currency = base_lines[0]['currency_id']
-        reduced_amount_currency = self._compute_subset_base_lines_total(base_lines)
-        delta_reduced_amount_currency = currency.round(target_amount_currency - reduced_amount_currency)
         for base_line in base_lines:
             taxes_data = base_line['tax_details']['taxes_data']
             if not taxes_data:
@@ -2831,6 +2841,8 @@ def _apply_base_lines_manual_amounts_to_reach(self, base_lines, target_amount_cu
                 base_line['manual_tax_amounts'][str(tax.id)] = tax_amounts
 
         # Smooth distribution of the delta accross the base line, starting at the biggest one.
+        reduced_amount_currency = self._compute_subset_base_lines_total(base_lines)
+        delta_reduced_amount_currency = currency.round(target_amount_currency - reduced_amount_currency)
         sorted_base_lines = sorted(
             [
                 base_line
@@ -2845,13 +2857,16 @@ def _apply_base_lines_manual_amounts_to_reach(self, base_lines, target_amount_cu
             if not nb_cents_to_distribute:
                 break
 
-            nb_cents = min(
-                max(
-                    math.ceil(abs(base_line['tax_details']['total_excluded_currency']) * nb_cents_to_distribute / total_excluded_currency),
-                    0.0,
-                ),
-                nb_cents_to_distribute,
-            )
+            if currency.is_zero(total_excluded_currency):
+                nb_cents = nb_cents_to_distribute
+            else:
+                nb_cents = min(
+                    max(
+                        math.ceil(abs(base_line['tax_details']['total_excluded_currency']) * nb_cents_to_distribute / total_excluded_currency),
+                        0.0,
+                    ),
+                    nb_cents_to_distribute,
+                )
             nb_cents_to_distribute -= nb_cents
             delta = sign * nb_cents * currency.rounding
 
@@ -2866,7 +2881,7 @@ def _apply_base_lines_manual_amounts_to_reach(self, base_lines, target_amount_cu
                 if tax in first_batch:
                     base_line['manual_tax_amounts'][str(tax.id)]['base_amount_currency'] += delta
                 else:
-                    return
+                    break
 
     @api.model
     def _prepare_global_discount_lines(
@@ -2949,27 +2964,26 @@ def _prepare_global_discount_lines(
             target_amount_currency = currency.round(total_currency * -percentage)
 
         # Apply the percentage to each line.
-        reduced_base_lines = []
-        new_base_lines = self._reduce_base_lines_with_grouping_function(discountable_base_lines, grouping_function=grouping_function)
-        for base_line in new_base_lines:
-            reduced_base_line = self._prepare_base_line_for_taxes_computation(
+        new_base_lines = []
+        for base_line in discountable_base_lines:
+            new_base_line = self._prepare_base_line_for_taxes_computation(
                 base_line,
                 computation_key=computation_key,
                 price_unit=base_line['price_unit'] * -percentage,
             )
-            self._add_tax_details_in_base_line(reduced_base_line, company)
+            self._add_tax_details_in_base_line(new_base_line, company)
 
             # Propagate custom values.
             for k, v in base_line.items():
-                if k not in reduced_base_line:
-                    reduced_base_line[k] = v
+                if k not in new_base_line:
+                    new_base_line[k] = v
 
-            reduced_base_lines.append(reduced_base_line)
+            new_base_lines.append(new_base_line)
 
-        if reduced_base_lines:
-            self._round_base_lines_tax_details(reduced_base_lines, company)
-            self._apply_base_lines_manual_amounts_to_reach(reduced_base_lines, target_amount_currency)
-        return reduced_base_lines
+        if new_base_lines:
+            self._round_base_lines_tax_details(new_base_lines, company)
+            self._apply_base_lines_manual_amounts_to_reach(new_base_lines, target_amount_currency)
+        return self._reduce_base_lines_with_grouping_function(new_base_lines, grouping_function=grouping_function)
 
     @api.model
     def _prepare_down_payment_lines(
@@ -3060,27 +3074,26 @@ def _prepare_down_payment_lines(
             target_amount_currency = currency.round(total_currency * percentage)
 
         # Apply the percentage to each line.
-        reduced_base_lines = []
-        new_base_lines = self._reduce_base_lines_with_grouping_function(discountable_base_lines, grouping_function=grouping_function)
-        for base_line in new_base_lines:
-            reduced_base_line = self._prepare_base_line_for_taxes_computation(
+        new_base_lines = []
+        for base_line in discountable_base_lines:
+            new_base_line = self._prepare_base_line_for_taxes_computation(
                 base_line,
                 computation_key=computation_key,
                 price_unit=base_line['price_unit'] * percentage,
             )
-            self._add_tax_details_in_base_line(reduced_base_line, company)
+            self._add_tax_details_in_base_line(new_base_line, company)
 
             # Propagate custom values.
             for k, v in base_line.items():
-                if k not in reduced_base_line:
-                    reduced_base_line[k] = v
+                if k not in new_base_line:
+                    new_base_line[k] = v
 
-            reduced_base_lines.append(reduced_base_line)
+            new_base_lines.append(new_base_line)
 
-        if reduced_base_lines:
-            self._round_base_lines_tax_details(reduced_base_lines, company)
-            self._apply_base_lines_manual_amounts_to_reach(reduced_base_lines, target_amount_currency)
-        return reduced_base_lines
+        if new_base_lines:
+            self._round_base_lines_tax_details(new_base_lines, company)
+            self._apply_base_lines_manual_amounts_to_reach(new_base_lines, target_amount_currency)
+        return self._reduce_base_lines_with_grouping_function(new_base_lines, grouping_function=grouping_function)
 
     # -------------------------------------------------------------------------
     # END HELPERS IN BOTH PYTHON/JAVASCRIPT (account_tax.js)

addons/account/models/partner.py

@@ -603,7 +603,6 @@ def _default_display_invoice_template_pdf_report_id(self):
     duplicated_bank_account_partners_count = fields.Integer(
         compute='_compute_duplicated_bank_account_partners_count',
     )
-    is_coa_installed = fields.Boolean(store=False, default=lambda partner: bool(partner.env.company.chart_template))
 
     property_outbound_payment_method_line_id = fields.Many2one(
         comodel_name='account.payment.method.line',

addons/account/report/account_invoice_report.py

@@ -118,11 +118,11 @@ def _select(self) -> SQL:
                    0.0) * account_currency_table.rate                               AS price_average,
                 CASE
                     WHEN move.move_type NOT IN ('out_invoice', 'out_receipt', 'out_refund') THEN 0.0
-                    WHEN move.move_type = 'out_refund' THEN -line.balance * account_currency_table.rate + (line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0)) * COALESCE(product.standard_price -> line.company_id::text, to_jsonb(0.0))::float
-                    ELSE -line.balance * account_currency_table.rate - (line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0)) * COALESCE(product.standard_price -> line.company_id::text, to_jsonb(0.0))::float
+                    WHEN move.move_type = 'out_refund' THEN account_currency_table.rate * (-line.balance + (line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0)) * COALESCE(product.standard_price -> line.company_id::text, to_jsonb(0.0))::float)
+                    ELSE account_currency_table.rate * (-line.balance - (line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0)) * COALESCE(product.standard_price -> line.company_id::text, to_jsonb(0.0))::float)
                 END
                                                                             AS price_margin,
-                line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0) * (CASE WHEN move.move_type IN ('out_invoice','in_refund','out_receipt') THEN -1 ELSE 1 END)
+                account_currency_table.rate * line.quantity / NULLIF(COALESCE(uom_line.factor, 1) / COALESCE(uom_template.factor, 1), 0.0) * (CASE WHEN move.move_type IN ('out_invoice','in_refund','out_receipt') THEN -1 ELSE 1 END)
                     * COALESCE(product.standard_price -> line.company_id::text, to_jsonb(0.0))::float                    AS inventory_value,
                 COALESCE(partner.country_id, commercial_partner.country_id) AS country_id,
                 line.currency_id                                            AS currency_id