Skip to content

[IMP] *: adapt tests for mysterious egg #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aans-odoo
Copy link

@aans-odoo aans-odoo commented May 7, 2025

This PR adapts the selector and enables some of the disabled tests for master-mysterious-egg.

@robodoo
Copy link

robodoo commented May 7, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@aans-odoo aans-odoo changed the title [IMP] website: adapt tests for mysterious egg [IMP] *: adapt tests for mysterious egg May 7, 2025
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch 5 times, most recently from fac2153 to d158faa Compare May 16, 2025 04:47
@msh-odoo msh-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from d158faa to 6710977 Compare May 16, 2025 06:41
Copy link

@msh-odoo msh-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have added 2 remarks, please check that.

Comment on lines 604 to 606
if page:
if page.view_id.website_meta_description:
result['description'] = page.view_id.website_meta_description

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if page:
if page.view_id.website_meta_description:
result['description'] = page.view_id.website_meta_description
if page and page.view_id.website_meta_description:
result['description'] = page.view_id.website_meta_description

Comment on lines 58 to 60
{
trigger: ":iframe body:contains(welcome to your)",
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this step is removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have this welcome message in the editor + the previous step was enough verify that menu is saved!

@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from 6710977 to 8bdcc9e Compare May 16, 2025 07:14
@aans-odoo
Copy link
Author

@msh-odoo, suggested changes have been made, thanks.

@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from 8bdcc9e to 8d688cc Compare May 19, 2025 12:19
@msh-odoo msh-odoo marked this pull request as ready for review May 20, 2025 05:22
@robodoo
Copy link

robodoo commented May 20, 2025

This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged.

@msh-odoo
Copy link

@ged-odoo @FrancoisGe Ready for review, would you please review and merge?

@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch from 5b240d1 to 558b8e7 Compare May 20, 2025 05:41
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from 8d688cc to 72ffdce Compare May 20, 2025 07:20
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch 5 times, most recently from edff5d7 to d31ecfa Compare May 21, 2025 13:57
@FrancoisGe FrancoisGe force-pushed the master-mysterious-egg branch 3 times, most recently from 314790f to 48edd7d Compare May 22, 2025 06:44
@ged-odoo ged-odoo force-pushed the master-mysterious-egg branch from 48edd7d to 54b7266 Compare May 22, 2025 08:18
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from 72ffdce to 0b84db0 Compare May 22, 2025 09:17
@aans-odoo aans-odoo changed the base branch from master-mysterious-egg to master-mysterious-egg-next May 22, 2025 09:32
Since odoo#203903 the user `im_status` is sent directly from the identity
model in order to take into account other module overrides without
having to re-establish them client side.
This commit removes the method patching `updateImStatus` as the
value arrives client side already patched from `hr_holidays`.

closes odoo#209495

X-original-commit: 7163947
Signed-off-by: Matthieu Stockbauer (tsm) <[email protected]>
Polymorphe57 and others added 15 commits May 23, 2025 00:51
We revert partially the commit 5a1825c: we split and describe facets
like before. Several things are kept:

- we maintain the order of the facets: when a domain is edited/split, we
insert the corresponding facets where the old one was.
- we handle the groupbys of a favorite in the kanban view in the same way
- a facet not modified is not split and kept as it was before the opening
of the domain selector dialog.

Task ID: 4798097

Part-of: odoo#210131
Related: odoo/enterprise#85880
Signed-off-by: Mathieu Duckerts-Antoine (dam) <[email protected]>
We modify the display of some operators in the search bar facets and
the domain selector in readonly mode. The operators <= and >= are
removed since they can be reconstructed easily with the other operators.
The simplification of trees is done more carefully: it keeps the order
of the children.

Task ID: 4798097

Part-of: odoo#210131
Related: odoo/enterprise#85880
Signed-off-by: Mathieu Duckerts-Antoine (dam) <[email protected]>
The facet tooltips for the custom filters now look like to what is
displayed in the domain selector in readonly mode.

Task ID: 4798097

closes odoo#210131

Related: odoo/enterprise#85880
Signed-off-by: Mathieu Duckerts-Antoine (dam) <[email protected]>
- Changed 'In Progress' tag from green to orange to indicate that  further
  actions are still required.
- Changed 'Paid' tag from grey to green, as no further user action is needed.
- Task Id: 4797098

closes odoo#211171

X-original-commit: b7f6e36
Signed-off-by: Josse Colpaert (jco) <[email protected]>
Signed-off-by: Smit Joshi (smjo) <[email protected]>
closes odoo#210902

X-original-commit: fbe6f2a
Signed-off-by: Martin Trigaux (mat) <[email protected]>
Continuation of the fix:
7de3b32

closes odoo#211181

Signed-off-by: Rémy Voet (ryv) <[email protected]>
Follow-up of odoo#210304

PR above improve message actions placement in mobile in card layout,
such as in Inbox. However it makes a regression in placement of other
message actions.

This commit fixes the issue by keeping the card visual of message
actions as the fix for card layout and same visual as before the
fix for non-card messages.

closes odoo#211104

X-original-commit: 80009d2
Signed-off-by: Alexandre Kühn (aku) <[email protected]>
This commit introduces manual input for lines 01, 04, 10, and 25 in the mod.111
report. The previous automatic calculation based on tax tags was unreliable and
could produce inaccurate values, so manual entry ensures the data correctly
reflects actual figures.

task-4797773

closes odoo#211178

X-original-commit: 97fe24c
Signed-off-by: Josse Colpaert (jco) <[email protected]>
Signed-off-by: Harsh Trivedi (hatr) <[email protected]>
This commit fixes the `disconnect during vacuum should ask for reload`
test that was non-deterministic as it was triggering websocket
reconnection too early, resulting in the wrong event being sent.

fixes runbot-223185

closes odoo#211185

X-original-commit: 024b1c4
Signed-off-by: Didier Debondt (did) <[email protected]>
Before this patch, it was impossible to resequence vendor bills if already sent to SII/tbai.

However, it is required to be able to resequence them, and the move name isn't sent anymore since odoo#195113 was merged.

Thus, here I'm lifting that constraint to allow accountants do the resequencing.

@moduon MT-8728 OPW-4567144

closes odoo#211092

X-original-commit: 91056d8
Signed-off-by: Josse Colpaert (jco) <[email protected]>
…round_per_line

- Fix wrong 'return' instead of 'break'
- Fix '_import_base_line_extra_tax_data':

>>> float_round(1196.8849999999998, precision_digits=2)
1196.89
>>> currency.compare_amounts(1196.89, 1196.8849999999998)
0
>>> currency.is_zero(1196.89 - 1196.8849999999998)
False

We have to use the float comparison instead of subtracting them.

- Fix delta distribution for down payment/global discount using round_per_line:

Currently, when doing a down payment, we aggregate the base lines first.
Then, we fix the tax amounts using manual_tax_amounts and then, we distribute the delta
to reach the expected value.
That way is too global and becomes an issue when using round_per_line.
For example, when performing a down payment of 100%, we could end up with
a base and tax amounts that are not the same than the original document.

So this commit changes a bit the logic by fixing the tax amounts using manual_tax_amounts
first. Then, we aggregate the lines including manual_tax_amounts.
Then, we distribute the delta.
That way, the results is way closer to a round_per_line computation
when choosen.

opw-4685953

closes odoo#211129

X-original-commit: cd3b5b1
Related: odoo/enterprise#86135
Signed-off-by: Antoine Dupuis (andu) <[email protected]>
Signed-off-by: Laurent Smet (las) <[email protected]>
*: base, base_automation, mail, sms

This commit simplifies server actions automated naming and makes the
related necessary changes to the kanban view as well.

Task id: opw-4736084

closes odoo#207706

Related: odoo/enterprise#84271
Signed-off-by: Lucas Perais (lpe) <[email protected]>
When selecting an even row by clicking on it (if it's not opening a
record) or by selecting the checkbox and then unchecking it, it will
highlight this row. This is only working on even rows but not on odd
rows.

This fix aims to make even and odd rows work correctly by being
highlighted.

task-4809597

closes odoo#211241

X-original-commit: caa72ae
Signed-off-by: Aaron Bohy (aab) <[email protected]>
Signed-off-by: Léo Leclerc (leol) <[email protected]>
task-4675788

closes odoo#210990

Signed-off-by: Sébastien Theys (seb) <[email protected]>
Abandoned cart emails would send twice because the email values for the
abandoned cart template would include the partner on the record already,
but we were also including the partner email in the email values.

Adjusted the email values to be empty when there is already a recipient
found on the template.

opw-4684534

closes odoo#210725

X-original-commit: aeae389
Signed-off-by: Valentin Chevalier <[email protected]>
Signed-off-by: Ryan Cen (ryce) <[email protected]>
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch 3 times, most recently from 5e1e3f7 to c671259 Compare May 23, 2025 07:05
Ricardo-MC and others added 3 commits May 23, 2025 07:41
closes odoo#211224

X-original-commit: b37eaa2
Signed-off-by: Martin Trigaux (mat) <[email protected]>
This commit improves the user experience of many2one and many2many
autocomplete fields by visually highlighting the portion of each
suggestion that matches the user's input. This provides clearer
feedback during search and enhances usability.

task-4707431

closes odoo#211015

X-original-commit: bac11cc
Related: odoo/enterprise#86073
Signed-off-by: Bastien Pierre (ipb) <[email protected]>
Signed-off-by: Julien Carion (juca) <[email protected]>
In order to update a record using a sequence:
- before this commit one would have to use a python expression like
  `env['ir.sequence'].next_by_code('the_sequence_code')` which was not
  very discoverable.
- after this commit there is a standard way to select a sequence through
  the server action's form view.

Task id: opw-4689501

closes odoo#208376

Signed-off-by: Lucas Perais (lpe) <[email protected]>
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from c671259 to 4a0d476 Compare May 23, 2025 12:01
aans-odoo added 6 commits May 23, 2025 17:42
`snippet_carousel_autoplay` tour was broken and disabled after the new
website builder changes.

This commit adapts the tour steps accordingly and re-enables the related
test.
`test_01_wishlist_tour` test was disabled after the new website builder
changes. This commit re-enables this test.
`test_autocomplete` test was disabled after the new website builder
changes. This commit re-enables this test.
Previously, the link popover did not support frontend website pages
(e.g., /contactus, /shop, etc.).

Steps to reproduce:
- Enter edit mode.
- Click on a link to a frontend page, such as "Contact Us".
- An error was thrown in the browser console.
- Also, the link popover did not show the page description (even if it
  existed).

This commit:
- Fixes the error that occurred in the browser console.
- Adds support for frontend website pages in the link popover.
- Displays the page description in the linkpopover, if available.
  (The page description refers to the SEO field that can be set via:
  Site > This Page > Optimize SEO > Description)
`megamenu_active_nav_link` tour was broken and disabled after the new
website builder changes.

This commit adapts the tour steps accordingly and re-enables the related
test.
`edit_menus` tour was broken and disabled after the new website builder
changes.

This commit adapts the tour steps accordingly and re-enables the related
test.
@aans-odoo aans-odoo force-pushed the master-mysterious-egg-tour-adaption-5-aans branch from 4a0d476 to e1ceb86 Compare May 23, 2025 12:13
@aans-odoo aans-odoo closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.