Screencast session restore for Wayland / PipeWire #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used by the next commit to verify whether or not to pass the restore token and persist mode options.
With the version 4 of the screencast portal, it is now possible to request and use restore tokens [1] so that apps can restore a previously configured screencast session without user interaction. Add the corresponding code to linux-capture's PipeWire source. Store the restore token in the source data, since each restore token corresponds to an OBS source, and use it as soon as we try to create a new session. Implement the obs_source_info.save vfunc, and save the restore token when it's received by the Start() response using obs_source_save(). [1] flatpak/xdg-desktop-portal#638
GeorgesStavracas
added
Enhancement
GeorgesStavracas
changed the title
|
Are there any issues tracking implementation on other platforms you can link? |
I just opened https://bugs.kde.org/show_bug.cgi?id=445875 and emersion/xdg-desktop-portal-wlr#170 - not entirely sure it's a good idea for them to be in the commit message, do you have any preference? |
|
I agree it doesnt make sense in the commit message. I just wanted to know if other implementations actually were tracking the effort of implementing this functionality or not. |
columbarius
reviewed
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement restoring screencast sessions using portals. Do so by storing the restore token received by the portal in the source data, and using it next time the source is loaded. This feature is only available in the v4 version of the ScreenCast portal [1] - if an older version is running in the host system, the current behavior is preserved.
Motivation and Context
Currently OBS Studio has to recreate screencast sessions from scratch each time a PipeWire source is loaded. This can be annoying,
Use the new screencast restore options provided by xdg-desktop-portal to restore previous sessions.
How Has This Been Tested?
OBS_USE_EGL=1Types of changes
Checklist:
[1] flatpak/xdg-desktop-portal#638
[2] This is not a GNOME-specific feature; it's just the only implementation available at this point. KDE folks reviewed and approved this new feature, and might be working on their implementation.